base/test/trace_event_analyzer_unittest.cc - Issue 8590015: trace_event: distinguish between scoped begin/end and global start/finish events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 8590015: trace_event: distinguish between scoped begin/end and global start/finish events (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ETW test compile Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/debug/trace_event.cc ('K') | « base/test/trace_event_analyzer.cc ('k') | chrome/browser/resources/tracing/tests/start_finish.json » ('j') | chrome/browser/resources/tracing/tests/start_finish.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/test/trace_event_analyzer_unittest.cc

diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc

index a95413fc6e1b5b92d13199004f136d6d608bc342..583785083adf583759bc4e209de32e6b556de713 100644

--- a/base/test/trace_event_analyzer_unittest.cc

+++ b/base/test/trace_event_analyzer_unittest.cc

@@ -108,7 +108,7 @@ TEST_F(TraceEventAnalyzerTest, QueryEventMember) {

event.thread.process_id = 3;

event.thread.thread_id = 4;

event.timestamp = 1.5;

- event.phase = base::debug::TRACE_EVENT_PHASE_BEGIN;

+ event.phase = TRACE_EVENT_PHASE_BEGIN;

event.category = "category";

event.name = "name";

event.arg_numbers["num"] = 7.0;

@@ -119,7 +119,7 @@ TEST_F(TraceEventAnalyzerTest, QueryEventMember) {

other.thread.process_id = 5;

other.thread.thread_id = 6;

other.timestamp = 2.5;

- other.phase = base::debug::TRACE_EVENT_PHASE_END;

+ other.phase = TRACE_EVENT_PHASE_END;

other.category = "category2";

other.name = "name2";

other.arg_numbers["num2"] = 8.0;