trace_event: distinguish between scoped begin/end and global start/finish events

base/test/trace_event_analyzer.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Use trace_analyzer::Query and trace_analyzer::TraceAnalyzer to search for
 // specific trace events that were generated by the trace_event.h API.
 //
 // Basic procedure:
 // - Get trace events JSON string from base::debug::TraceLog.
 // - Create TraceAnalyzer with JSON string.
@@ skipping 235 matching lines @@
 
   // Compare with the given string pattern. Only works with == and != operators.
   // Example: Query(EVENT_NAME) == Query::Pattern("MyEvent*")
   static Query Pattern(const std::string& pattern);
 
   // Common queries:
 
   // Find BEGIN events that have a corresponding END event.
   static Query MatchBeginWithEnd() {
     return (Query(EVENT_PHASE) ==
-            Query::Phase(base::debug::TRACE_EVENT_PHASE_BEGIN)) &&
+            Query::Phase(TRACE_EVENT_PHASE_BEGIN)) &&
            Query(EVENT_HAS_OTHER);
   }
 
   // Find BEGIN events of given |name| which also have associated END events.
   static Query MatchBeginName(const std::string& name) {
     return (Query(EVENT_NAME) == name) && MatchBeginWithEnd();
   }
 
   // Match given Process ID and Thread ID.
   static Query MatchThread(const TraceEvent::ProcessThreadID& thread) {
@@ skipping 138 matching lines @@
 
   Query query_;
 };
 
 // TraceAnalyzer helps tests search for trace events.
 class TraceAnalyzer {
  public:
   typedef std::vector<const TraceEvent*> TraceEventVector;
 
   struct Stats {
     double min_us;

[jar (doing other things), 2011/12/02 00:09:32]

nit: Abbreviations are frowned on... IMO, *_microseconds would be simpler... and
not a big deal to type.

...yeah... I saw "us" was used in time.h.... but that was probably not a great
idea.  It gets worse when you look at:
mean_us

We're not that mean! ;-)

     double max_us;
     double mean_us;
     double standard_deviation_us;
   };
 
   ~TraceAnalyzer();
 
   // Use trace events from JSON string generated by tracing API.
   // Returns non-NULL if the JSON is successfully parsed.
   static TraceAnalyzer* Create(const std::string& json_events)
@@ skipping 57 matching lines @@
   std::map<TraceEvent::ProcessThreadID, std::string> thread_names_;
   std::vector<TraceEvent> raw_events_;
   bool allow_assocation_changes_;
 
   DISALLOW_COPY_AND_ASSIGN(TraceAnalyzer);
 };
 
 }  // namespace trace_analyzer
 
 #endif  // BASE_TEST_TRACE_EVENT_ANALYZER_H_