Issue 8590010: Valgrind: Fix the gcc 4.2 mac build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8590010: Valgrind: Fix the gcc 4.2 mac build. (Closed)

Created:
9 years, 1 month ago by James Hawkins

Modified:
9 years, 1 month ago

Reviewers:
groby-ooo-7-16, Nico

CC:
chromium-reviews, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Valgrind: Fix the gcc 4.2 mac build. BUG=none TEST=none R=groby@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110390

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	ui/base/keycodes/keyboard_code_conversion.cc	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

We shouldn't have a valgrind bot that builds with gcc. If there is one, please ...

9 years, 1 month ago (2011-11-17 03:51:47 UTC) #3

James Hawkins

On 2011/11/17 03:51:47, Nico wrote: > We shouldn't have a valgrind bot that builds with ...

9 years, 1 month ago (2011-11-17 04:30:28 UTC) #4

Nico

9 years, 1 month ago (2011-11-17 05:35:37 UTC) #5

On Wed, Nov 16, 2011 at 8:30 PM,  <jhawkins@chromium.org> wrote:
> On 2011/11/17 03:51:47, Nico wrote:
>>
>> We shouldn't have a valgrind bot that builds with gcc. If there is one,
>> please
>> point me to it.
>
> Nico:
>
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Webkit%20Mac%20%28va...

Thanks, filed http://code.google.com/p/chromium/issues/detail?id=104583

Expand Messages | Collapse Messages