Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/sync/engine/net/server_connection_manager.cc

Issue 8590005: sync: remove IncrementErrorCount from ServerConnectionManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/net/server_connection_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/net/server_connection_manager.cc
diff --git a/chrome/browser/sync/engine/net/server_connection_manager.cc b/chrome/browser/sync/engine/net/server_connection_manager.cc
index bceb18713f1e6e192b78d169917e8f2cdb6e9edd..b0d7c2fddd98858922dbc110c8c9ab109f7f0b6f 100644
--- a/chrome/browser/sync/engine/net/server_connection_manager.cc
+++ b/chrome/browser/sync/engine/net/server_connection_manager.cc
@@ -180,7 +180,6 @@ ServerConnectionManager::ServerConnectionManager(
use_ssl_(use_ssl),
proto_sync_path_(kSyncServerSyncPath),
get_time_path_(kSyncServerGetTimePath),
- error_count_(0),
server_status_(HttpResponse::NONE),
server_reachable_(false),
terminated_(false),
@@ -252,14 +251,11 @@ bool ServerConnectionManager::PostBufferToPath(PostBufferParams* params,
bool ok = post.get()->Init(
path.c_str(), auth_token, params->buffer_in, &params->response);
- if (params->response.server_status == HttpResponse::SYNC_AUTH_ERROR) {
+ if (params->response.server_status == HttpResponse::SYNC_AUTH_ERROR)
InvalidateAndClearAuthToken();
- }
- if (!ok || RC_REQUEST_OK != params->response.response_code) {
- IncrementErrorCount();
+ if (!ok || RC_REQUEST_OK != params->response.response_code)
return false;
- }
if (post.get()->ReadBufferResponse(
&params->buffer_out, &params->response, true)) {
@@ -311,7 +307,6 @@ bool ServerConnectionManager::CheckTime(int32* out_time) {
VLOG(1) << "Server was reachable.";
return true;
}
- IncrementErrorCount();
return false;
}
@@ -336,25 +331,6 @@ bool ServerConnectionManager::CheckServerReachable() {
return server_is_reachable;
}
-bool ServerConnectionManager::IncrementErrorCount() {
- DCHECK(thread_checker_.CalledOnValidThread());
- error_count_++;
-
- if (error_count_ > kMaxConnectionErrorsBeforeReset) {
- error_count_ = 0;
-
- if (!IsServerReachable()) {
- LOG(WARNING) << "Too many connection failures, server is not reachable. "
- << "Resetting connections.";
- } else {
- LOG(WARNING) << "Multiple connection failures while server is reachable.";
- }
- return false;
- }
-
- return true;
-}
-
void ServerConnectionManager::SetServerParameters(const string& server_url,
int port,
bool use_ssl) {
« no previous file with comments | « chrome/browser/sync/engine/net/server_connection_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698