Issue 8590005: sync: remove IncrementErrorCount from ServerConnectionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8590005: sync: remove IncrementErrorCount from ServerConnectionManager. (Closed)

Created:
9 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
rlarocque

CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, cbentzel+watch_chromium.org, darin-cc_chromium.org, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: remove IncrementErrorCount from ServerConnectionManager. It's not used for a real purpose anymore, and it was causing the SCM to have multiple active_connection_ objects in certain cases, which is bad. This is mostly covered by SyncAPIServerConnectionManagerTest BUG=101639 TEST=On a debug build, no DCHECKs if the server is unreachable on sync startup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110443

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -36 lines)			Patch
	M	chrome/browser/sync/engine/net/server_connection_manager.h	View		3 chunks	+0 lines, -10 lines	0 comments	Download
	M	chrome/browser/sync/engine/net/server_connection_manager.cc	View		4 chunks	+2 lines, -26 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/8590005/1

9 years, 1 month ago (2011-11-16 23:00:20 UTC) #3

commit-bot: I haz the power

Try job failure for 8590005-1 (retry) on linux_rel for step "unit_tests". It's a second try, ...

9 years, 1 month ago (2011-11-16 23:53:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/8590005/1

9 years, 1 month ago (2011-11-17 00:40:10 UTC) #5

Change committed as 110443

Expand Messages | Collapse Messages