chrome: Remove 11 exit time destructors and 4 static initializers.

chrome: Remove 11 exit time destructors and 4 static initializers.

BUG=101600, 94925
TEST=none
TBR=erg,willchan

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110447

[Mark Mentovai, 2011-11-16 22:54:24]

Check the try server, too. Some targets aren’t clean yet.

http://codereview.chromium.org/8590003/diff/1/chrome/browser/net/network_stat...
File chrome/browser/net/network_stats.cc (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/net/network_stat...
chrome/browser/net/network_stats.cc:542:
CR_DEFINE_STATIC_LOCAL(scoped_refptr<base::FieldTrial>, trial, (NULL));
You can use () instead of (NULL) here.

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list.cc
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:121:
CR_DEFINE_STATIC_LOCAL(BrowserList::BrowserVector, b, ());
Something better than b? (And b on 126 and o on 131?)

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:775: result++;
For consistency with the preincrement two lines above, use preincrement here
too. (I know this is just moving.)

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/webui/chrome_...
File chrome/browser/ui/webui/chrome_url_data_manager.h (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/webui/chrome_...
chrome/browser/ui/webui/chrome_url_data_manager.h:181: // Protected by a
g_delete_lock.
What’s a g_delete_lock?

1. Get rid of the “a”.

2. Since g_delete_lock is nowhere to be found here, this comment could specify
“protected by g_delete_lock in the .cc file.”

[Nico, 2011-11-16 22:59:20]

trybots are fine; lkgr is just too old and doesn't have the changes I checked in
earlier today.

http://codereview.chromium.org/8590003/diff/1/chrome/browser/net/network_stat...
File chrome/browser/net/network_stats.cc (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/net/network_stat...
chrome/browser/net/network_stats.cc:542:
CR_DEFINE_STATIC_LOCAL(scoped_refptr<base::FieldTrial>, trial, (NULL));
On 2011/11/16 22:54:24, Mark Mentovai wrote:
> You can use () instead of (NULL) here.

Done.

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list.cc
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:121:
CR_DEFINE_STATIC_LOCAL(BrowserList::BrowserVector, b, ());
On 2011/11/16 22:54:24, Mark Mentovai wrote:
> Something better than b? (And b on 126 and o on 131?)

c?

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/browser_list....
chrome/browser/ui/browser_list.cc:775: result++;
On 2011/11/16 22:54:24, Mark Mentovai wrote:
> For consistency with the preincrement two lines above, use preincrement here
> too. (I know this is just moving.)

Done.

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/webui/chrome_...
File chrome/browser/ui/webui/chrome_url_data_manager.h (right):

http://codereview.chromium.org/8590003/diff/1/chrome/browser/ui/webui/chrome_...
chrome/browser/ui/webui/chrome_url_data_manager.h:181: // Protected by a
g_delete_lock.
On 2011/11/16 22:54:24, Mark Mentovai wrote:
> What’s a g_delete_lock?
> 
> 1. Get rid of the “a”.
> 
> 2. Since g_delete_lock is nowhere to be found here, this comment could specify
> “protected by g_delete_lock in the .cc file.”

Done.

[Mark Mentovai, 2011-11-17 00:22:42]

LGTM

[commit-bot: I haz the power, 2011-11-17 00:29:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8590003/5002

[commit-bot: I haz the power, 2011-11-17 00:29:18]

Presubmit check for 8590003-5002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/profiles/profile_manager.cc,chrome/browser/net/network_stats.cc

Presubmit checks took 2.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Nico, 2011-11-17 00:31:36]

willchan, erg: OWNERS stamps please (willchan for c/b/net, erg for c/b/profiles)

[commit-bot: I haz the power, 2011-11-17 00:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8590003/5002

[willchan no longer on Chromium, 2011-11-17 00:40:30]

LGTM for both chrome/browser/net and chrome/browser/profiles.

[commit-bot: I haz the power, 2011-11-17 02:01:30]

Try job failure for 8590003-5002 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-11-17 02:07:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8590003/6002

[Nico, 2011-11-17 02:27:15]

ChromeOS isn't ready for turning this on. I'm removing the gyp changes from this
CL :-(

[commit-bot: I haz the power, 2011-11-17 02:28:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8590003/3019

[commit-bot: I haz the power, 2011-11-17 06:06:17]

Change committed as 110447

[joth, 2011-11-18 01:18:14]

http://codereview.chromium.org/8590003/diff/3019/chrome/browser/ui/browser_li...
File chrome/browser/ui/browser_list.cc (right):

http://codereview.chromium.org/8590003/diff/3019/chrome/browser/ui/browser_li...
chrome/browser/ui/browser_list.cc:130: static
ObserverList<BrowserList::Observer>& observers() {
again non-const refs