Issue 8590001: Cache the results of merging/filtering/grouping data in about:profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8590001: Cache the results of merging/filtering/grouping data in about:profiler. (Closed)

Created:
9 years, 1 month ago by eroman

Modified:
9 years, 1 month ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Cache the results of merging/filtering/grouping data in about:profiler. This avoids having to recompute certain bits of data during display (for instance, there is no need to re-merge/group the data when simply changing the sorting order). BUG=100992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110453

Patch Set 1 #

Patch Set 2 : Make comment better #

Total comments: 1

Patch Set 3 : re-upload to make sure file hasn't changed... #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -83 lines)			Patch
	M	chrome/browser/resources/profiler.js	View	1	8 chunks	+120 lines, -83 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

9 years, 1 month ago (2011-11-17 02:40:31 UTC) #2

lgtm

http://codereview.chromium.org/8590001/diff/3001/chrome/browser/resources/pro...
File chrome/browser/resources/profiler.js (right):

http://codereview.chromium.org/8590001/diff/3001/chrome/browser/resources/pro...
chrome/browser/resources/profiler.js:1290: // Data goes through the following
pipeline:
This sort of comment is quite helpful.

Expand Messages | Collapse Messages