Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 8589033: [Sync] Change std::wstring to string16 in SyncSetupFlowHandler. (Closed)

Created:
9 years, 1 month ago by binji
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

[Sync] Change std::wstring to string16 in SyncSetupFlowHandler. BUG=99665 TEST=everything compiles. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/browser/sync/sync_setup_flow.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
binji
9 years, 1 month ago (2011-11-18 21:21:02 UTC) #1
James Hawkins
lgtm
9 years, 1 month ago (2011-11-18 21:22:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8589033/1
9 years, 1 month ago (2011-11-18 23:58:16 UTC) #3
commit-bot: I haz the power
Presubmit check for 8589033-1 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-18 23:58:20 UTC) #4
binji
+zea for OWNERS
9 years, 1 month ago (2011-11-19 00:01:44 UTC) #5
Nicolas Zea
lgtm
9 years, 1 month ago (2011-11-19 00:02:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8589033/1
9 years, 1 month ago (2011-11-19 00:07:19 UTC) #7
commit-bot: I haz the power
Try job failure for 8589033-1 (retry) (retry) (retry) on linux_rel for step "ui_tests". It's a ...
9 years, 1 month ago (2011-11-19 02:13:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/8589033/1
9 years, 1 month ago (2011-11-21 21:18:28 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 23:10:08 UTC) #10
Change committed as 111029

Powered by Google App Engine
This is Rietveld 408576698