[Sync Setup] Change the "sync everything" dialog "Learn more" link.

[Sync Setup] Change the "sync everything" dialog "Learn more" link.
Also, move some URL constants to url_constants.h/cc.

BUG=103324
TEST=Go to chrome://settings/personal. Sign in to sync. Choose "Sync Everything". The learn more link should go to http://...answer=185277.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114070

[James Hawkins, 2011-11-17 21:39:07]

LGTM with nit.

http://codereview.chromium.org/8589014/diff/1/chrome/browser/ui/webui/sync_se...
File chrome/browser/ui/webui/sync_setup_handler.cc (right):

http://codereview.chromium.org/8589014/diff/1/chrome/browser/ui/webui/sync_se...
chrome/browser/ui/webui/sync_setup_handler.cc:298: std::string
create_account_url = google_util::StringAppendGoogleLocaleParam(
nit: Remove extra space at EOL.

[commit-bot: I haz the power, 2011-11-28 21:42:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8589014/1

[commit-bot: I haz the power, 2011-11-28 21:43:00]

Can't apply patch for file chrome/browser/resources/sync_setup_overlay.html.
While running patch -p1 --forward --force;
patching file chrome/browser/resources/sync_setup_overlay.html
Hunk #4 FAILED at 84.
Hunk #5 succeeded at 140 (offset 2 lines).
1 out of 5 hunks FAILED -- saving rejects to file
chrome/browser/resources/sync_setup_overlay.html.rej

[commit-bot: I haz the power, 2011-11-28 22:49:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8589014/5001

[commit-bot: I haz the power, 2011-11-28 23:41:58]

Try job failure for 8589014-5001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2011-11-29 21:37:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8589014/5001

[commit-bot: I haz the power, 2011-11-30 00:02:47]

Try job failure for 8589014-5001 (retry) on win_rel for steps "browser_tests,
ui_tests".
It's a second try, previously, steps "unit_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-12-12 19:13:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/8589014/11001

[commit-bot: I haz the power, 2011-12-12 20:27:31]

Change committed as 114070