Issue 8589013: Add build_webkit_exes_from_webkit_gyp flag to build/common.gypi

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8589013: Add build_webkit_exes_from_webkit_gyp flag to build/common.gypi (Closed)

Created:
9 years, 1 month ago by Dirk Pranke

Modified:
9 years, 1 month ago

Reviewers:
tony, darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add build_webkit_exes_from_webkit_gyp flag to build/common.gypi This is the first step in splitting up the circular dependencies between DRT, webkit_support, and webkit. This change should be a no-op for now. R=tony@chromium.org BUG=https://bugs.webkit.org/show_bug.cgi?id=68463 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111436

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -13 lines)			Patch
	M	build/common.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	webkit/webkit.gyp	View		1 chunk	+36 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

9 years, 1 month ago (2011-11-18 00:33:56 UTC) #4

On 2011/11/17 19:49:05, Dirk Pranke wrote:
> Darin, can I get an owner approval?

LGTM

Expand Messages | Collapse Messages