Disable GViewRequestInterceptorTest.InterceptPdfWithNoPlugin on official builds.

Disable GViewRequestInterceptorTest.InterceptPdfWithNoPlugin on official builds.

the test doesn't make much sense on officail builds, and it fails on them

BUG=104566
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110454

[tbarzic, 2011-11-17 01:33:56]

please, take a look..

[Dan Beam, 2011-11-17 01:35:38]

lgtm (btw, I'm only provisional, might need to add thestig@chromium.org as well
to get "LGTM from valid reviewers")

[tbarzic, 2011-11-17 01:39:35]

On 2011/11/17 01:35:38, Dan Beam wrote:
> lgtm (btw, I'm only provisional, might need to add mailto:thestig@chromium.org
as well
> to get "LGTM from valid reviewers")

ok, will add him..

[Lei Zhang, 2011-11-17 01:40:08]

http://codereview.chromium.org/8589010/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor_unittest.cc (right):

http://codereview.chromium.org/8589010/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor_unittest.cc:247: #if
defined(OFFICIAL_BUILD)
just put: #if !defined(OFFICIAL_BUILD) around the test and add a comment to
indicate why this test only run on non-official builds.

Using DISABLED_ indicates there's something wrong with the test and it had to be
disabled, and someone will try to fix and re-enable the test.

[tbarzic, 2011-11-17 01:49:00]

http://codereview.chromium.org/8589010/diff/1/chrome/browser/chromeos/gview_r...
File chrome/browser/chromeos/gview_request_interceptor_unittest.cc (right):

http://codereview.chromium.org/8589010/diff/1/chrome/browser/chromeos/gview_r...
chrome/browser/chromeos/gview_request_interceptor_unittest.cc:247: #if
defined(OFFICIAL_BUILD)
On 2011/11/17 01:40:09, Lei Zhang wrote:
> just put: #if !defined(OFFICIAL_BUILD) around the test and add a comment to
> indicate why this test only run on non-official builds.
> 
> Using DISABLED_ indicates there's something wrong with the test and it had to
be
> disabled, and someone will try to fix and re-enable the test.

Done.

[Lei Zhang, 2011-11-17 01:49:31]

lgtm

[commit-bot: I haz the power, 2011-11-17 03:05:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/8589010/3003

[commit-bot: I haz the power, 2011-11-17 06:14:43]

Change committed as 110454