Pepper: Add some simple tests for most functions in the PPB_Flash interface.

Pepper: Add some simple tests for most functions in the PPB_Flash interface.

BUG=104560
TEST=ui_tests {OutOfProcessPPAPITest,PPAPITest}.Flash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110580

[yzshen1, 2011-11-17 01:39:45]

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc
File ppapi/tests/test_flash.cc (right):

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:24: flash_interface_ = reinterpret_cast<PPB_Flash
const*>(
nit: maybe it is better to keep const at the same position as the declaration of
flash_interface_.

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:29: void TestFlash::RunTest() {
I thought a filter string is needed?

[dmichael (off chromium), 2011-11-17 04:10:46]

LGTM once you use the new RunTests and 'filter' style.

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc
File ppapi/tests/test_flash.cc (right):

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:24: flash_interface_ = reinterpret_cast<PPB_Flash
const*>(
static_cast

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.h
File ppapi/tests/test_flash.h (right):

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.h#newcode22
ppapi/tests/test_flash.h:22: virtual void RunTest();
This is now 'RunTests(const std::string& filter)'

[viettrungluu, 2011-11-17 19:13:39]

Thanks.

Maybe I'll go through and fix the const and reinterpret_cast in other files, so
when I cargo-cult code it'll at least be right....

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc
File ppapi/tests/test_flash.cc (right):

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:24: flash_interface_ = reinterpret_cast<PPB_Flash
const*>(
On 2011/11/17 01:39:45, yzshen1 wrote:
> nit: maybe it is better to keep const at the same position as the declaration
of
> flash_interface_.

Done.

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:24: flash_interface_ = reinterpret_cast<PPB_Flash
const*>(
On 2011/11/17 01:39:45, yzshen1 wrote:
> nit: maybe it is better to keep const at the same position as the declaration
of
> flash_interface_.

Done.

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.cc#newco...
ppapi/tests/test_flash.cc:29: void TestFlash::RunTest() {
On 2011/11/17 01:39:45, yzshen1 wrote:
> I thought a filter string is needed?

Yeah, I was working off a stale tree and rebasing didn't catch this, obviously!

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.h
File ppapi/tests/test_flash.h (right):

http://codereview.chromium.org/8589009/diff/1/ppapi/tests/test_flash.h#newcode22
ppapi/tests/test_flash.h:22: virtual void RunTest();
On 2011/11/17 04:10:46, dmichael wrote:
> This is now 'RunTests(const std::string& filter)'

Done.

[yzshen1, 2011-11-17 19:14:49]

lgtm

[commit-bot: I haz the power, 2011-11-17 21:28:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/8589009/2002

[commit-bot: I haz the power, 2011-11-17 22:41:56]

Change committed as 110580

[James Hawkins, 2011-11-17 23:44:26]

This seems to have caused consistent failures on the Mac UI (valgrind)(1) bot.

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20UI%...