Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: content/common/sandbox_mac_unittest_helper.h

Issue 8589001: Load mac sandbox definitions from resources instead of the bundle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: also remove old bundle gyp code Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_mac_unittest_helper.h
diff --git a/content/common/sandbox_mac_unittest_helper.h b/content/common/sandbox_mac_unittest_helper.h
index f228678a2bf5e2890751ccac8302bb3d171be5ff..3affe91c59c3c71934e2a88ca1d20434c5b8c971 100644
--- a/content/common/sandbox_mac_unittest_helper.h
+++ b/content/common/sandbox_mac_unittest_helper.h
@@ -45,12 +45,12 @@ namespace sandboxtest {
// a given test in the sandbox.
class MacSandboxTest : public base::MultiProcessTest {
public:
- // Runs a test specified by |test_name| in a sandbox of the type specified
- // by |sandbox_type|. |test_data| is a custom string that a test can pass
- // to the child process runing in the sandbox.
+ // Runs a test specified by |test_name| in a sandbox of the type specified by
Jói 2011/11/17 13:50:21 type specified by -> as defined by the resource wi
+ // |sandbox_definition_resource_id|. |test_data| is a custom string that a
+ // test can pass to the child process runing in the sandbox.
// Returns true if the test passes, false if either of the functions in
// the corresponding MacSandboxTestCase return false.
- bool RunTestInSandbox(sandbox::Sandbox::SandboxProcessType sandbox_type,
+ bool RunTestInSandbox(int sandbox_definition_resource_id,
const char* test_name,
const char* test_data);

Powered by Google App Engine
This is Rietveld 408576698