Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: content/public/common/sandbox_init.h

Issue 8589001: Load mac sandbox definitions from resources instead of the bundle. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: different approach Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/sandbox_init.h
diff --git a/content/public/common/sandbox_init.h b/content/public/common/sandbox_init.h
index 3415e0d4abb8e2e9ba33986add4141e7dc1f07e9..a51da0cfdcab5e09c3837ed6eee4c30b6a96a5a0 100644
--- a/content/public/common/sandbox_init.h
+++ b/content/public/common/sandbox_init.h
@@ -13,10 +13,13 @@
namespace sandbox {
struct SandboxInterfaceInfo;
}
+#elif defined(OS_MACOSX)
+class FilePath;
#endif
namespace content {
+#if defined(OS_WIN)
// Initialize the sandbox for renderer, gpu, utility, worker, nacl, and plug-in
// processes, depending on the command line flags. Although The browser process
// is not sandboxed, this also needs to be called because it will initialize
@@ -24,11 +27,23 @@ namespace content {
// Returns true if the sandbox was initialized succesfully, false if an error
// occurred. If process_type isn't one that needs sandboxing true is always
// returned.
-#if defined(OS_WIN)
CONTENT_EXPORT bool InitializeSandbox(
sandbox::SandboxInterfaceInfo* sandbox_info);
#elif defined(OS_MACOSX)
-CONTENT_EXPORT bool InitializeSandbox();
+// Initialize the sandbox of the given |sandbox_type|, optionally specifying a
+// directory to allow access to. This needs to be supported by the sandbox
+// policy associated with the given |sandbox_type|.
+//
+// The sandbox policy to use for this |sandbox_type| is queried using
+// ContentClient::GetSandboxPolicyForSandboxType(). The embedder can use values
+// for |sandbox_type| starting from
+// content::sandbox::SANDBOX_AFTER_TYPE_LAST_TYPE.
jeremy 2011/11/23 07:02:17 We need the unit tests to run on all sandbox types
jochen (gone - plz use gerrit) 2011/11/23 10:57:28 The embedder will have to test their own definitio
+//
+// Returns true if the sandbox was initialized succesfully, false if an error
+// occurred. If process_type isn't one that needs sandboxing true is always
+// returned.
+CONTENT_EXPORT bool InitializeSandbox(int sandbox_type,
+ const FilePath& allowed_path);
#endif
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698