Refactor to allow same code to test both sync and async functions.

Refactor to allow same code to test both sync and async functions.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111050

[asargent_no_longer_on_chrome, 2011-11-18 23:08:18]

http://codereview.chromium.org/8588067/diff/2001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_function_test_utils.h (right):

http://codereview.chromium.org/8588067/diff/2001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_function_test_utils.h:53: // ownership of
|function|.
nit: remove this line about caller releasing ownership, since that contradicts
the sentence you added. And thinking about it a little more, this wasn't even
true becuse UIThreadExtensionFunction is ref-counted, so all we do is addref
while we're using the function (via a scoped_refptr), and don't really care if
anyone else has a reference or not as long as they aren't doing things like
calling methods on it while we are.

http://codereview.chromium.org/8588067/diff/2001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_function_test_utils.h:95: bool
RunAsyncFunction(UIThreadExtensionFunction* function,
I thought Aaron's idea was that we want to get rid of the distinction between
RunFunction and RunAsyncFunction, and just have RunFunction.

[miket_OOO, 2011-11-18 23:22:04]

Changes made.

[asargent_no_longer_on_chrome, 2011-11-21 17:18:43]

lgtm

[commit-bot: I haz the power, 2011-11-21 22:18:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8588067/8001

[commit-bot: I haz the power, 2011-11-22 00:20:34]

Change committed as 111050