Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Issue 8588066: Fix a bug that incorrectly kicked off the upgrade task. (Closed)

Created:
9 years, 1 month ago by csilv
Modified:
9 years, 1 month ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a bug that incorrectly kicked off the upgrade task. BUG=104790 TEST=Launch app, verify that upgrade is not detected inappropriately. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/upgrade_detector_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
csilv
+jhawkins for review
9 years, 1 month ago (2011-11-18 21:25:55 UTC) #1
csilv
On 2011/11/18 21:25:55, csilv wrote: > +jhawkins for review I converted the destructor incorrectly, in ...
9 years, 1 month ago (2011-11-18 21:28:08 UTC) #2
James Hawkins
My bad for not catching this. LGTM
9 years, 1 month ago (2011-11-18 21:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csilv@chromium.org/8588066/1
9 years, 1 month ago (2011-11-18 21:32:00 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 22:27:10 UTC) #5
Try job failure for 8588066-1 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698