Issue 8588063: Remove TODOs for copying FFmpeg binaries for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8588063: Remove TODOs for copying FFmpeg binaries for Mac. (Closed)

Created:
9 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, tony

CC:
chromium-reviews, darin-cc_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove TODOs for copying FFmpeg binaries for Mac. Due to how Mac applications are bundled we require the application target itself to be responsible for copying FFmpeg. BUG=23602 TBR=mark,tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110734

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	chrome/chrome_dll.gypi	View		1 chunk	+2 lines, -4 lines	0 comments	Download
	M	webkit/tools/test_shell/test_shell.gypi	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM2

Expand Messages | Collapse Messages