Implementation of window_snapshot_aura

Implementation of window_snapshot_aura

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111166

[sky, 2011-11-18 19:03:44]

http://codereview.chromium.org/8588058/diff/9/chrome/browser/ui/window_snapsh...
File chrome/browser/ui/window_snapshot/window_snapshot_aura.cc (right):

http://codereview.chromium.org/8588058/diff/9/chrome/browser/ui/window_snapsh...
chrome/browser/ui/window_snapshot/window_snapshot_aura.cc:19: ui::Compositor*
compositor = aura::Desktop::GetInstance()->compositor();
Get the compositor from window's layer.

http://codereview.chromium.org/8588058/diff/9/chrome/browser/ui/window_snapsh...
chrome/browser/ui/window_snapshot/window_snapshot_aura.cc:29: if
(!compositor->ReadPixels(&bitmap, desktop_snapshot_bounds))
I believe the coordinates passed to the compositor are wrong. You're passing
coordinates relative to the window when they need to be relative to the root.

[jonathan.backer, 2011-11-18 19:37:38]

http://codereview.chromium.org/8588058/diff/9/chrome/browser/ui/window_snapsh...
File chrome/browser/ui/window_snapshot/window_snapshot_aura.cc (right):

http://codereview.chromium.org/8588058/diff/9/chrome/browser/ui/window_snapsh...
chrome/browser/ui/window_snapshot/window_snapshot_aura.cc:29: if
(!compositor->ReadPixels(&bitmap, desktop_snapshot_bounds))
Are you missing a file? or is this based off of another CL? My pull from this
morning on has ReadPixels taking one parameter.

[pkotwicz, 2011-11-18 19:49:40]

Depends on
http://codereview.chromium.org/8523022/ http://codereview.chromium.org/8561016/

[pkotwicz, 2011-11-18 20:33:45]

Changes as requested

[sky, 2011-11-18 21:08:06]

LGTM

http://codereview.chromium.org/8588058/diff/4003/chrome/browser/ui/window_sna...
File chrome/browser/ui/window_snapshot/window_snapshot_aura.cc (right):

http://codereview.chromium.org/8588058/diff/4003/chrome/browser/ui/window_sna...
chrome/browser/ui/window_snapshot/window_snapshot_aura.cc:9: #include
"ui/aura/desktop.h"
remove desktop include.