Add a mid-sized integration test for the Dart Embedding Api which

runtime/lib/isolate.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart.h"
 #include "vm/dart_entry.h"
@@ skipping 69 matching lines @@
   str ^= String::Concat(str, name);
   GrowableArray<const Object*> arguments(1);
   arguments.Add(&str);
   Exceptions::ThrowByType(type, arguments);
 }
 
 
 RawInstance* ReceivePortCreate(intptr_t port_id) {
   const String& class_name =
       String::Handle(String::NewSymbol("ReceivePortImpl"));
-  const String& function_name = String::Handle(String::NewSymbol("create_"));
+  const String& function_name = String::Handle(String::NewSymbol("_create"));
   const int kNumArguments = 1;
   const Array& kNoArgumentNames = Array::Handle();
   const Function& function = Function::Handle(
       Resolver::ResolveStatic(Library::Handle(Library::CoreLibrary()),
                               class_name,
                               function_name,
                               kNumArguments,
                               kNoArgumentNames,
                               Resolver::kIsQualified));
   GrowableArray<const Object*> arguments(kNumArguments);
   arguments.Add(&Integer::Handle(Integer::New(port_id)));
   const Instance& result = Instance::Handle(
       DartEntry::InvokeStatic(function, arguments, kNoArgumentNames));
   if (result.IsUnhandledException()) {
     UnhandledException& uhe = UnhandledException::Handle();
     uhe ^= result.raw();
     ProcessUnhandledException(uhe);
+  } else {
+    PortMap::SetLive(port_id);

[siva, 2011/11/29 19:50:27]

I think we should add a comment that a port once it becomes live will become non
live only if it is closed. That is not obvious when reading the code. The dart
reference is held in the port_map object ensuring that the reference is not
lost.

[turnidge, 2011/12/05 17:53:34]

Added comment in port.h.

On 2011/11/29 19:50:27, asiva wrote:

   }
   return result.raw();
 }
 
 
 static RawInstance* SendPortCreate(intptr_t port_id) {
   const String& class_name = String::Handle(String::NewSymbol("SendPortImpl"));
-  const String& function_name = String::Handle(String::NewSymbol("create_"));
+  const String& function_name = String::Handle(String::NewSymbol("_create"));
   const int kNumArguments = 1;
   const Array& kNoArgumentNames = Array::Handle();
   const Function& function = Function::Handle(
       Resolver::ResolveStatic(Library::Handle(Library::CoreLibrary()),
                               class_name,
                               function_name,
                               kNumArguments,
                               kNoArgumentNames,
                               Resolver::kIsQualified));
   GrowableArray<const Object*> arguments(kNumArguments);
@@ skipping 143 matching lines @@
     spawned_isolate->set_long_jump_base(&jump);
     if (setjmp(*jump.Set()) == 0) {
       Dart::InitializeIsolate(NULL, preserved_isolate->init_callback_data());
     } else {
       init_successful = false;
     }
     spawned_isolate->set_long_jump_base(base);
     // Check arguments to see if the specified library and classes are
     // loaded, this check will throw an exception if they are not loaded.
     if (init_successful && CheckArguments(library_url, class_name)) {
-      port_id = PortMap::CreatePort();
+      port_id = spawned_isolate->main_port();
       uword data = reinterpret_cast<uword>(
           new IsolateStartData(spawned_isolate,
                                strdup(library_url),
                                strdup(class_name),
                                port_id));
       new Thread(RunIsolate, data);
     } else {
       // Error spawning the isolate, maybe due to initialization errors or
       // errors while loading the application into spawned isolate, shut
       // it down and report error.
@@ skipping 57 matching lines @@
   intptr_t send_id = Smi::CheckedHandle(arguments->At(0)).Value();
   intptr_t reply_id = Smi::CheckedHandle(arguments->At(1)).Value();
   // TODO(iposva): Allow for arbitrary messages to be sent.
   void* data = SerializeObject(Instance::CheckedHandle(arguments->At(2)));
 
   // TODO(turnidge): Throw an exception when the return value is false?
   PortMap::PostMessage(send_id, reply_id, data);
 }
 
 }  // namespace dart