Add a mid-sized integration test for the Dart Embedding Api which

runtime/vm/isolate.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 
 #include "vm/assert.h"
 #include "vm/bigint_store.h"
@@ skipping 19 matching lines @@
     "Count function invocations and report.");
 DECLARE_FLAG(bool, generate_gdb_symbols);
 
 
 Isolate::Isolate()
     : store_buffer_(),
       message_queue_(NULL),
       post_message_callback_(NULL),
       close_port_callback_(NULL),
       active_ports_(0),
+      main_port_(0),

[siva, 2011/11/24 00:52:31]

maybe -1 would be better value or we should have an assert in
PortMap::InitOnce() that PortMap::next_port_ is not initialized to 0.

[turnidge, 2011/11/29 01:01:31]

There is already an assert in PortMap::AllocatePort.  We also use 0 as a special
value in dart_api.h for kNoReplyPort and kCloseAllPorts.

       heap_(NULL),
       object_store_(NULL),
       top_resource_(NULL),
       top_context_(Context::null()),
       current_zone_(NULL),
 #if defined(DEBUG)
       no_gc_scope_depth_(0),
       no_handle_scope_depth_(0),
       top_handle_scope_(NULL),
 #endif
@@ skipping 68 matching lines @@
   // Setup the Dart API state.
   ApiState* state = new ApiState();
   ASSERT(state != NULL);
   result->set_api_state(state);
 
   // Initialize stack top and limit in case we are running the isolate in the
   // main thread.
   // TODO(5411455): Need to figure out how to set the stack limit for the
   // main thread.
   result->SetStackLimitFromCurrentTOS(reinterpret_cast<uword>(&result));
+  result->set_main_port(PortMap::CreatePort());
 
   return result;
 }
 
 
 // TODO(5411455): Use flag to override default value and Validate the
 // stack size by querying OS.
 uword Isolate::GetSpecifiedStackSize() {
   uword stack_size = Isolate::kDefaultStackSize - Isolate::kStackSizeBuffer;
   return stack_size;
@@ skipping 96 matching lines @@
 Dart_IsolateInitCallback Isolate::InitCallback() {
   return init_callback_;
 }
 
 
 void Isolate::StandardRunLoop() {
   ASSERT(long_jump_base() != NULL);
   ASSERT(post_message_callback() == &StandardPostMessageCallback);
   ASSERT(close_port_callback() == &StandardClosePortCallback);
 
-  while (active_ports() > 0) {
+  while (Dart_HasLivePorts()) {

[siva, 2011/11/24 00:52:31]

Seems pretty expensive to call a dart function from here to determine if there
are live ports. Since we are in the VM is there a way to get this data directly.

[turnidge, 2011/11/29 01:01:31]

Now this uses live_ports() > 0.

     ASSERT(this == Isolate::Current());
     Zone zone(this);
     HandleScope handle_scope(this);
 
     PortMessage* message = message_queue()->Dequeue(0);
     if (message != NULL) {
       Dart_Handle result = Dart_HandleMessage(
           message->dest_port(), message->reply_port(), message->data());
       if (Dart_IsError(result)) {
         fprintf(stderr, "%s\n", Dart_GetError(result));
@@ skipping 34 matching lines @@
   // Visit all objects in the code index table.
   if (code_index_table() != NULL) {
     code_index_table()->VisitObjectPointers(visitor);
   }
 
   // Visit the top context which is stored in the isolate.
   visitor->VisitPointer(reinterpret_cast<RawObject**>(&top_context_));
 }
 
 }  // namespace dart