Add a mid-sized integration test for the Dart Embedding Api which

runtime/vm/port.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/port.h"
 
 #include "vm/isolate.h"
 #include "vm/thread.h"
 #include "vm/utils.h"
 
@@ skipping 72 matching lines @@
   } else if (empty < deleted_) {
     // Rehash without growing the table to flush the deleted slots out of the
     // map.
     Rehash(capacity_);
   }
 }
 
 
 Dart_Port PortMap::CreatePort() {
   Isolate* isolate = Isolate::Current();
+  Dart_Port port;
+  {
+    MutexLocker ml(mutex_);
 
-  MutexLocker ml(mutex_);
+    Entry entry;
+    port = AllocatePort();
+    entry.port = port;
+    entry.isolate = isolate;
 
-  Entry entry;
-  entry.port = AllocatePort();
-  entry.isolate = isolate;
+    // Search for the first unused slot. Make use of the knowledge that here is
+    // currently no port with this id in the port map.
+    ASSERT(FindPort(entry.port) < 0);
+    intptr_t index = entry.port % capacity_;
+    Entry cur = map_[index];
+    // Stop the search at the first found unused (free or deleted) slot.
+    while (cur.port != 0) {
+      index = (index + 1) % capacity_;
+      cur = map_[index];
+    }
 
-  // Search for the first unused slot. Make use of the knowledge that here is
-  // currently no port with this id in the port map.
-  ASSERT(FindPort(entry.port) < 0);
-  intptr_t index = entry.port % capacity_;
-  Entry cur = map_[index];
-  // Stop the search at the first found unused (free or deleted) slot.
-  while (cur.port != 0) {
-    index = (index + 1) % capacity_;
-    cur = map_[index];
+    // Insert the newly created port at the index.
+    ASSERT(index >= 0);
+    ASSERT(index < capacity_);
+    ASSERT(map_[index].port == 0);
+    ASSERT((map_[index].isolate == NULL) ||
+           (map_[index].isolate == deleted_entry_));
+    if (map_[index].isolate == deleted_entry_) {
+      // Consuming a deleted entry.
+      deleted_--;
+    }
+    map_[index] = entry;
+    isolate->increment_active_ports();
+
+    // Increment number of used slots and grow if necessary.
+    used_++;
+    MaintainInvariants();
   }
 
-  // Insert the newly created port at the index.
-  ASSERT(index >= 0);
-  ASSERT(index < capacity_);
-  ASSERT(map_[index].port == 0);
-  ASSERT((map_[index].isolate == NULL) ||
-         (map_[index].isolate == deleted_entry_));
-  if (map_[index].isolate == deleted_entry_) {
-    // Consuming a deleted entry.
-    deleted_--;
-  }
-  map_[index] = entry;
-  isolate->increment_active_ports();
+  // Notify the embedder that this port has been created.
+  Dart_CreatePortCallback callback = isolate->create_port_callback();
+  ASSERT(callback);
+  (*callback)(isolate, port);
 
-  // Increment number of used slots and grow if necessary.
-  used_++;
-  MaintainInvariants();
-
-  return entry.port;
+  return port;
 }
 
 
 void PortMap::ClosePort(Dart_Port port) {
   Isolate* isolate = Isolate::Current();
   {
     MutexLocker ml(mutex_);
     intptr_t index = FindPort(port);
     if (index < 0) {
       return;
@@ skipping 16 matching lines @@
   // Notify the embedder that this port is closed.
   Dart_ClosePortCallback callback = isolate->close_port_callback();
   ASSERT(callback);
   ASSERT(port != kCloseAllPorts);
   (*callback)(isolate, port);
 }
 
 
 void PortMap::ClosePorts() {
   Isolate* isolate = Isolate::Current();
+  if (isolate->active_ports() == 0) {
+    return;
+  }
   {
     MutexLocker ml(mutex_);
     for (intptr_t i = 0; i < capacity_; i++) {
       if (map_[i].isolate == isolate) {
         // Mark the slot as deleted.
         map_[i].port = 0;
         map_[i].isolate = deleted_entry_;
         isolate->decrement_active_ports();
 
         used_--;
@@ skipping 50 matching lines @@
   ASSERT(Utils::IsPowerOfTwo(kInitialCapacity));
   map_ = new Entry[kInitialCapacity];
   memset(map_, 0, kInitialCapacity * sizeof(Entry));
   capacity_ = kInitialCapacity;
   used_ = 0;
   deleted_ = 0;
 }
 
 
 }  // namespace dart