Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 8588037: Updates to DownloadItemGtk for supporting download items marked as DANGEROUS_CONTENT. (Closed)

Created:
9 years, 1 month ago by asanka
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Updates to DownloadItemGtk for supporting download items marked as DANGEROUS_CONTENT. ownloads that are flagged as malicious based on content will have a danger type of DANGEROUS_CONTENT. BUG=102540 TEST=Downloading a binary identified as malicious by the Safe Browsing service shows a warning dialog in the download shelf.

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -73 lines) Patch
M chrome/browser/ui/gtk/download/download_item_gtk.h View 1 2 chunks +5 lines, -0 lines 1 comment Download
M chrome/browser/ui/gtk/download/download_item_gtk.cc View 1 2 7 chunks +98 lines, -70 lines 1 comment Download
M content/browser/download/download_state_info.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
asanka
9 years, 1 month ago (2011-11-19 00:41:59 UTC) #1
Randy Smith (Not in Mondays)
Evan, could you take a look? I don't know the GTK code very well. Minor ...
9 years, 1 month ago (2011-11-21 01:38:13 UTC) #2
Randy Smith (Not in Mondays)
What's the status of this CL? Is it going in with low priority since this ...
9 years ago (2011-12-07 21:00:16 UTC) #3
asanka
9 years ago (2011-12-07 21:05:43 UTC) #4
On 2011/12/07 21:00:16, rdsmith wrote:
> What's the status of this CL?  Is it going in with low priority since this
case
> won't happen in the near term on Linux, or is it DOA?

On hold for now.  The current patchset implements the older malicious download
UI.  I'll resurrect it with the new UI once things stabilize on Windows.

Powered by Google App Engine
This is Rietveld 408576698