Improve support for multiselect list box accessibility on Windows.

content/browser/accessibility/browser_accessibility_win.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_WIN_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_WIN_H_
 #pragma once
 
 #include <atlbase.h>
 #include <atlcom.h>
@@ skipping 176 matching lines @@
 
   CONTENT_EXPORT STDMETHODIMP get_nRelations(LONG* n_relations);
 
   CONTENT_EXPORT STDMETHODIMP get_relation(LONG relation_index,
                                            IAccessibleRelation** relation);
 
   CONTENT_EXPORT STDMETHODIMP get_relations(LONG max_relations,
       IAccessibleRelation** relations,
       LONG* n_relations);
 
+  CONTENT_EXPORT STDMETHODIMP get_groupPosition(LONG* group_level,
+                                                LONG* similar_items_in_group,
+                                                LONG* position_in_group);
+
   // IAccessible2 methods not implemented.
   CONTENT_EXPORT STDMETHODIMP get_extendedRole(BSTR* extended_role) {
     return E_NOTIMPL;
   }
   CONTENT_EXPORT STDMETHODIMP scrollTo(enum IA2ScrollType scroll_type) {
     return E_NOTIMPL;
   }
   CONTENT_EXPORT STDMETHODIMP scrollToPoint(
       enum IA2CoordinateType coordinate_type,
       LONG x,
       LONG y) {
     return E_NOTIMPL;
   }
-  CONTENT_EXPORT STDMETHODIMP get_groupPosition(LONG* group_level,
-                                                LONG* similar_items_in_group,
-                                                LONG* position_in_group) {
-    return E_NOTIMPL;
-  }
   CONTENT_EXPORT STDMETHODIMP get_localizedExtendedRole(
       BSTR* localized_extended_role) {
     return E_NOTIMPL;
   }
   CONTENT_EXPORT STDMETHODIMP get_nExtendedStates(LONG* n_extended_states) {
     return E_NOTIMPL;
   }
   CONTENT_EXPORT STDMETHODIMP get_extendedStates(LONG max_extended_states,
                                                  BSTR** extended_states,
                                                  LONG* n_extended_states) {
@@ skipping 490 matching lines @@
   bool first_time_;
 
   // The previous text, before the last update to this object.
   string16 previous_text_;
 
   // The old text to return in IAccessibleText::get_oldText - this is like
   // previous_text_ except that it's NOT updated when the object
   // is initialized again but the text doesn't change.
   string16 old_text_;
 
+  // The previous state, used to see if there was a state change.
+  int32 old_ia_state_;

[M-A Ruel, 2011/11/29 20:28:32]

I'd expect bitmaps to be uint32 ?

[dmazzoni, 2011/11/29 21:55:00]

This matches the signedness of the return type of the COM method that retrieves
the state.

[M-A Ruel, 2011/11/29 22:12:33]

Right, it's to support ole scripting, I had forgot about that.

+
   // Relationships between this node and other nodes.
   std::vector<BrowserAccessibilityRelation*> relations_;
 
   // Give BrowserAccessibility::Create access to our constructor.
   friend class BrowserAccessibility;
   friend class BrowserAccessibilityRelation;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityWin);
 };
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_WIN_H_