Improve support for multiselect list box accessibility on Windows.

base/win/enum_variant.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_WIN_ENUM_VARIANT_H_
+#define BASE_WIN_ENUM_VARIANT_H_
+#pragma once
+
+#include <unknwn.h>
+
+#include "base/memory/scoped_ptr.h"
+#include "base/win/iunknown_impl.h"
+
+namespace base {
+namespace win {
+
+// A simple implementation of IEnumVARIANT.
+class BASE_EXPORT EnumVariant
+  : public IEnumVARIANT,
+    public IUnknownImpl {
+ public:
+  // The constructor allocates an array of size |count|. Then use
+  // ItemAt to set the value of each item in the array to initialize it.
+  explicit EnumVariant(unsigned long count);

[M-A Ruel, 2011/11/29 20:28:32]

why do you alternate between unsigned long and ULONG? e.g. count_ is ULONG but
the argument is unsigned long.

[dmazzoni, 2011/11/29 21:55:00]

My intent was to use ULONG only in arguments and return values from COM methods.
Non-COM methods use the style that would be used in the rest of Chromium code.

The member variables were a mistake, I changed them to unsigned long.

+
+  // Returns a mutable pointer to the item at position |index|.
+  VARIANT* ItemAt(unsigned long index);
+
+  // IUnknown.
+  ULONG STDMETHODCALLTYPE AddRef() OVERRIDE;
+  ULONG STDMETHODCALLTYPE Release() OVERRIDE;
+  STDMETHODIMP QueryInterface(REFIID riid, void** ppv) OVERRIDE;
+
+  // IEnumVARIANT.
+  STDMETHODIMP Next(ULONG requested_count,
+                    VARIANT* out_elements,
+                    ULONG* out_elements_received);
+  STDMETHODIMP Skip(ULONG skip_count);
+  STDMETHODIMP Reset();
+  STDMETHODIMP Clone(IEnumVARIANT** out_cloned_object);
+
+ private:
+  ~EnumVariant();
+
+  scoped_array<VARIANT> items_;
+  ULONG count_;
+  ULONG current_index_;
+};
+
+}  // namespace win
+}  // namespace base
+
+#endif  // BASE_WIN_ENUM_VARIANT_H_