Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: content/renderer/media/webrtc_audio_device_unittest.cc

Issue 8588030: Refactor the Get*Hardware* routines a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_audio_device_unittest.cc
===================================================================
--- content/renderer/media/webrtc_audio_device_unittest.cc (revision 110480)
+++ content/renderer/media/webrtc_audio_device_unittest.cc (working copy)
@@ -15,6 +15,7 @@
#include "third_party/webrtc/voice_engine/main/interface/voe_network.h"
using testing::_;
+using testing::AnyNumber;
using testing::InvokeWithoutArgs;
using testing::Return;
using testing::StrEq;
@@ -117,7 +118,7 @@
// WebRtcAudioDeviceImpl.
TEST_F(WebRTCAudioDeviceTest, Construct) {
AudioUtilNoHardware audio_util(48000.0, 48000.0);
- set_audio_util_callback(&audio_util);
+ SetAudioUtilCallback(&audio_util);
scoped_refptr<WebRtcAudioDeviceImpl> audio_device(
new WebRtcAudioDeviceImpl());
audio_device->SetSessionId(1);
@@ -142,7 +143,7 @@
return;
AudioUtil audio_util;
- set_audio_util_callback(&audio_util);
+ SetAudioUtilCallback(&audio_util);
EXPECT_CALL(media_observer(),
OnSetAudioStreamStatus(_, 1, StrEq("created"))).Times(1);
@@ -151,7 +152,7 @@
EXPECT_CALL(media_observer(),
OnSetAudioStreamStatus(_, 1, StrEq("closed"))).Times(1);
EXPECT_CALL(media_observer(),
- OnDeleteAudioStream(_, 1)).Times(1);
+ OnDeleteAudioStream(_, 1)).Times(AnyNumber());
scoped_refptr<WebRtcAudioDeviceImpl> audio_device(
new WebRtcAudioDeviceImpl());
@@ -211,7 +212,7 @@
return;
AudioUtil audio_util;
- set_audio_util_callback(&audio_util);
+ SetAudioUtilCallback(&audio_util);
// TODO(tommi): extend MediaObserver and MockMediaObserver with support
// for new interfaces, like OnSetAudioStreamRecording(). When done, add
@@ -278,7 +279,7 @@
GetTestDataPath(FILE_PATH_LITERAL("speechmusic_mono_16kHz.pcm")));
AudioUtil audio_util;
- set_audio_util_callback(&audio_util);
+ SetAudioUtilCallback(&audio_util);
EXPECT_CALL(media_observer(),
OnSetAudioStreamStatus(_, 1, StrEq("created"))).Times(1);
@@ -287,7 +288,7 @@
EXPECT_CALL(media_observer(),
OnSetAudioStreamStatus(_, 1, StrEq("closed"))).Times(1);
EXPECT_CALL(media_observer(),
- OnDeleteAudioStream(_, 1)).Times(1);
+ OnDeleteAudioStream(_, 1)).Times(AnyNumber());
scoped_refptr<WebRtcAudioDeviceImpl> audio_device(
new WebRtcAudioDeviceImpl());
@@ -334,8 +335,15 @@
if (IsRunningHeadless())
return;
+ EXPECT_CALL(media_observer(),
+ OnSetAudioStreamStatus(_, 1, StrEq("created")));
+ EXPECT_CALL(media_observer(),
+ OnSetAudioStreamPlaying(_, 1, true));
+ EXPECT_CALL(media_observer(),
+ OnSetAudioStreamStatus(_, 1, StrEq("closed")));
+
AudioUtil audio_util;
- set_audio_util_callback(&audio_util);
+ SetAudioUtilCallback(&audio_util);
scoped_refptr<WebRtcAudioDeviceImpl> audio_device(
new WebRtcAudioDeviceImpl());
« no previous file with comments | « content/renderer/media/webrtc_audio_device_impl.cc ('k') | content/renderer/renderer_webkitplatformsupport_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698