Refactor the Get*Hardware* routines a bit.

Refactor the Get*Hardware* routines a bit.
These methods currently all have a static variable that caches the queried value.
This causes a problem in unit tests where values can change between tests.
I moved them outside of the AudioDevice class and grouped in their own namespace
which owns the globally cached state and allows the cache to be invalidated.

R=henrika
TEST=Run *WebRTC* tests in content.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110695

[tommi (sloooow) - chröme, 2011-11-17 12:12:36]

Adding crogers for AudioDevice changes, acolwell (media owner) and jamesr
(content/renderer owner).

[henrika (OOO until Aug 14), 2011-11-17 12:27:33]

Refactor based on namespace and I'll review it again.

audio_properties
audio_hardware
hardware_properties
device_properties

[henrika (OOO until Aug 14), 2011-11-17 12:27:44]

http://codereview.chromium.org/8588030/diff/1/content/renderer/media/audio_de...
File content/renderer/media/audio_device.h (right):

http://codereview.chromium.org/8588030/diff/1/content/renderer/media/audio_de...
content/renderer/media/audio_device.h:175: // Contains static methods to query
hardware properties from the browser
Namespace perhaps?

[tommi (sloooow) - chröme, 2011-11-17 13:06:52]

Done.  I moved the code to new files and into a namespace, audio_hardware.

[henrika (OOO until Aug 14), 2011-11-17 15:43:41]

LGTM. 

Check with Chris as well.

[acolwell GONE FROM CHROMIUM, 2011-11-17 16:38:47]

LGTM w/ trybot compile fixes obviously.

[scherkus (not reviewing), 2011-11-17 19:24:29]

driveby nit on namespace

nice change though! LGTM

http://codereview.chromium.org/8588030/diff/2019/content/renderer/media/audio...
File content/renderer/media/audio_hardware.h (right):

http://codereview.chromium.org/8588030/diff/2019/content/renderer/media/audio...
content/renderer/media/audio_hardware.h:32: };
nit: namespaces should end w/o semicolon as well as comment denoting which
namespace is ending


}  // namespace audio_hardware

[jamesr, 2011-11-17 19:29:39]

owners LGTM for content/renderer/renderer_webkitplatformsupport_impl.cc, did not
look at the rest of the patch

[Chris Rogers, 2011-11-17 20:50:14]

LGTM

[tommi (sloooow) - chröme, 2011-11-18 13:51:33]

Thanks everyone

http://codereview.chromium.org/8588030/diff/2019/content/renderer/media/audio...
File content/renderer/media/audio_hardware.h (right):

http://codereview.chromium.org/8588030/diff/2019/content/renderer/media/audio...
content/renderer/media/audio_hardware.h:32: };
On 2011/11/17 19:24:34, scherkus wrote:
> nit: namespaces should end w/o semicolon as well as comment denoting which
> namespace is ending
> 
> 
> }  // namespace audio_hardware

done.  (copy/paste oversight since this started out as a class)