Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8588028: Use the right command for dartc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/test_config_utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 2af6b329d239ba598d8e46f09627d48408787d2d..5ca47fcb3b69700e1a1a352e1510ccddc7893b1d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -37,7 +37,7 @@ String getExecutableName(Map configuration) {
case 'vm':
return 'dart_bin';
case 'dartc':
- return 'dartc';
+ return 'compiler/bin/dartc_test';
case 'frog':
case 'leg':
return 'frog/bin/frog';
@@ -109,7 +109,10 @@ class TestOutput {
bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
- bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode < 0;
+ // The Java dartc runner exits with code 253 in case of unhandles
+ // exceptions.
+ bool get hasCrashed() =>
+ !timedOut && (exitCode != -1) && ((exitCode < 0) || (exitCode == 253));
bool get hasTimedOut() => timedOut;
« no previous file with comments | « tools/testing/dart/test_config_utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698