Collect profiler stats from browser child processes.

content/public/browser/profiler_controller.h

Index: content/public/browser/profiler_controller.h
===================================================================
--- content/public/browser/profiler_controller.h	(revision 0)
+++ content/public/browser/profiler_controller.h	(revision 0)
@@ -0,0 +1,54 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_PROFILER_CONTROLLER_H_
+#define CONTENT_PUBLIC_BROWSER_PROFILER_CONTROLLER_H_
+
+#include <set>
+#include <string>
+
+#include "content/common/content_export.h"
+
+namespace base {
+class DictionaryValue;
+}
+
+namespace content {
+
+class ProfilerSubscriber;
+
+// Contact all processes and ask them to profiler data. It returns 2 to indicate

[jam, 2011/11/30 00:22:25]

it seems that these methods belong on ProfileController, instead of being static
functions.

[ramant (doing other things), 2011/11/30 19:37:21]

Done.

+// that ProfilerControllerImpl's OnPendingProcesses will be called once for

[jam, 2011/11/30 00:22:25]

nit: the comment in the interface shouldn't describe what happens internally. it
should just say that ProfilerSubscriber::OnPendingProcesses will be called

[ramant (doing other things), 2011/11/30 19:37:21]

Done.

+// renderer processes and another for browser child processes.
+CONTENT_EXPORT int GetProfilerData(int sequence_number);
+
+// Contact all processes and set profiler status to |enable|.
+CONTENT_EXPORT void SetProfilerStatus(bool enable);
+
+// ProfilerController is used on the browser process to collect profiler data.
+// Only the browser UI thread is allowed to interact with the ProfilerController
+// object.
+class CONTENT_EXPORT ProfilerController {
+ public:
+  // Returns the ProfilerController object for the current process, or NULL if
+  // none.
+  static ProfilerController* GetInstance();
+
+  virtual ~ProfilerController() {}
+
+  // Register the subscriber so that it will be called when for example
+  // OnProfilerDataCollected is returning profiler data from a child process.
+  // This is called on UI thread.
+  virtual void Register(ProfilerSubscriber* subscriber) = 0;
+
+  // Unregister the subscriber so that it will not be called when for example
+  // OnProfilerDataCollected is returning profiler data from a child process.
+  // Safe to call even if caller is not the current subscriber.
+  virtual void Unregister(ProfilerSubscriber* subscriber) = 0;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_PROFILER_CONTROLLER_H_
+
Property changes on: content\public\browser\profiler_controller.h
___________________________________________________________________
Added: svn:executable
   + *