fix NetInternalsTest.NetInternalsPrerenderViewSucceed for aura

The test failed because LauncherIconUpdater was holding a stale TabContentsWrapper and accessing its favicon helper. Add LauncherIconUpdater::TabReplaceAt so that we know when the TabContentsWrapper goes stale. 

BUG=104376
TEST=the test above.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110523

[sky, 2011-11-17 05:04:23]

http://codereview.chromium.org/8588020/diff/1/chrome/browser/ui/views/aura/la...
File chrome/browser/ui/views/aura/launcher_icon_updater.cc (right):

http://codereview.chromium.org/8588020/diff/1/chrome/browser/ui/views/aura/la...
chrome/browser/ui/views/aura/launcher_icon_updater.cc:95: tabs_.erase(i);
This should replace the value at i with new_contents, and invoke UpdateLauncher
if i < kMaxCount

[alicet1, 2011-11-17 05:33:38]

http://codereview.chromium.org/8588020/diff/1/chrome/browser/ui/views/aura/la...
File chrome/browser/ui/views/aura/launcher_icon_updater.cc (right):

http://codereview.chromium.org/8588020/diff/1/chrome/browser/ui/views/aura/la...
chrome/browser/ui/views/aura/launcher_icon_updater.cc:95: tabs_.erase(i);
On 2011/11/17 05:04:23, sky wrote:
> This should replace the value at i with new_contents, and invoke
UpdateLauncher
> if i < kMaxCount

Done.

[sky, 2011-11-17 16:01:48]

LGTM

[commit-bot: I haz the power, 2011-11-17 16:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alicet@chromium.org/8588020/4001

[commit-bot: I haz the power, 2011-11-17 18:11:05]

Change committed as 110523