chrome/browser/ui/webui/sync_setup_handler.cc - Issue 8588013: Fix crash in SyncSetupWizard::IsVisible()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_setup_handler.cc

Issue 8588013: Fix crash in SyncSetupWizard::IsVisible() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add browser test Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/sync_setup_handler.cc b/chrome/browser/ui/webui/sync_setup_handler.cc

index 914f823f745edb3a76a69797f61db8f241a93202..c1bad70264aed3562db447af5e1130fb5bf4e3f5 100644

--- a/chrome/browser/ui/webui/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/sync_setup_handler.cc

@@ -703,7 +703,9 @@ void SyncSetupHandler::OpenSyncSetup() {

bool SyncSetupHandler::FocusExistingWizard() {

Profile* profile = Profile::FromWebUI(web_ui_);

ProfileSyncService* service = profile->GetProfileSyncService();

- DCHECK(service);

+ if (!service)

+ return false;

// If the wizard is already visible, focus it.

if (service->get_wizard().IsVisible()) {

service->get_wizard().Focus();