Fix crash in SyncSetupWizard::IsVisible()

chrome/browser/extensions/extension_tabs_module.cc

Index: chrome/browser/extensions/extension_tabs_module.cc
diff --git a/chrome/browser/extensions/extension_tabs_module.cc b/chrome/browser/extensions/extension_tabs_module.cc
index a42096850aeccc6f71e96bbcceb37f91d2158e5f..8ce50cea823c49f3ccd4efd14dd4e697098fe3b0 100644
--- a/chrome/browser/extensions/extension_tabs_module.cc
+++ b/chrome/browser/extensions/extension_tabs_module.cc
@@ -277,18 +277,17 @@ bool CreateWindowFunction::ShouldOpenIncognitoWindow(
     incognito = true;
   }
 
-  // If we are opening an incognito window.
-  if (incognito) {
+  // Remove all URLs that are not allowed in an incognito session. Note that a
+  // ChromeOS guest session is not considered incognito in this case.
+  if (incognito && !Profile::IsGuestSession()) {
     std::string first_url_erased;
-    // Guest session is an exception as it always opens in incognito mode.
     for (size_t i = 0; i < urls->size();) {
-      if (browser::IsURLAllowedInIncognito((*urls)[i]) &&
-          !Profile::IsGuestSession()) {
+      if (browser::IsURLAllowedInIncognito((*urls)[i])) {
+        i++;
+      } else {
         if (first_url_erased.empty())
           first_url_erased = (*urls)[i].spec();
         urls->erase(urls->begin() + i);
-      } else {
-        i++;
       }
     }
     if (urls->empty() && !first_url_erased.empty()) {