Issue 8588009: use-gl=desktop mode got broken in r109111. GL proc addresses were not being found because ::GetPr...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8588009: use-gl=desktop mode got broken in r109111. GL proc addresses were not being found because ::GetPr... (Closed)

Created:
9 years, 1 month ago by alokp

Modified:
9 years, 1 month ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, nfullagar

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

use-gl=desktop mode got broken in r109111. GL proc addresses were not being found because ::GetProcAddress does not work with stock opengl32.dll. The stock dll just exposes GL 1.1 interface. wglGetProcAddress needs to be used to get >GL 1.1 interface, which in turn requires a GL current context. This patch simply reverts a portion of r109111. BUG=103765 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110455

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	ui/gfx/gl/gl_surface_wgl.cc	View	1	2 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alokp@chromium.org/8588009/3002

9 years, 1 month ago (2011-11-17 03:44:24 UTC) #3

Change committed as 110455

Expand Messages | Collapse Messages