Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6530)

Unified Diff: chrome/browser/ui/webui/chromeos/register_page_ui.cc

Issue 8588006: Eliminate CrosLibrary::EnsureLoaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/register_page_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/register_page_ui.cc b/chrome/browser/ui/webui/chromeos/register_page_ui.cc
index b6ad5fedd17e4f17cd9dd98b25a79ca82ff36e18..8bee89e72c2b037d746ff3d999fe6a5535b81e7d 100644
--- a/chrome/browser/ui/webui/chromeos/register_page_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/register_page_ui.cc
@@ -18,6 +18,7 @@
#include "chrome/browser/chromeos/cros/network_library.h"
#include "chrome/browser/chromeos/customization_document.h"
#include "chrome/browser/chromeos/login/wizard_controller.h"
+#include "chrome/browser/chromeos/system/runtime_environment.h"
#include "chrome/browser/chromeos/system/statistics_provider.h"
#include "chrome/browser/chromeos/version_loader.h"
#include "chrome/browser/profiles/profile.h"
@@ -62,11 +63,6 @@ const char kUndefinedValue[] = "undefined";
// Otherwise |kUndefinedValue| is returned.
#if defined(OS_CHROMEOS)
static std::string GetConnectionType() {
- if (!chromeos::CrosLibrary::Get()->EnsureLoaded()) {
- LOG(ERROR) << "CrosLibrary is not loaded.";
- return kUndefinedValue;
- }
-
chromeos::NetworkLibrary* network_lib =
chromeos::CrosLibrary::Get()->GetNetworkLibrary();
if (network_lib->ethernet_connected())
@@ -237,13 +233,13 @@ void RegisterPageHandler::HandleGetRegistrationUrl(const ListValue* args) {
void RegisterPageHandler::HandleGetUserInfo(const ListValue* args) {
#if defined(OS_CHROMEOS)
- if (chromeos::CrosLibrary::Get()->EnsureLoaded()) {
+ if (chromeos::system::runtime_environment::IsRunningOnChromeOS()) {
version_loader_.GetVersion(
&version_consumer_,
base::Bind(&RegisterPageHandler::OnVersion, base::Unretained(this)),
chromeos::VersionLoader::VERSION_FULL);
} else {
- SkipRegistration("CrosLibrary is not loaded.");
+ SkipRegistration("Not running on ChromeOS.");
}
#endif
}

Powered by Google App Engine
This is Rietveld 408576698