chrome/browser/chromeos/login/signed_settings.cc - Issue 8588006: Eliminate CrosLibrary::EnsureLoaded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signed_settings.cc

Issue 8588006: Eliminate CrosLibrary::EnsureLoaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/signed_settings.cc

diff --git a/chrome/browser/chromeos/login/signed_settings.cc b/chrome/browser/chromeos/login/signed_settings.cc

index 8b579ced2042b07093a82f04d797ec926599e2e0..9f563918a3a40d956e82507233c7217701d06185 100644

--- a/chrome/browser/chromeos/login/signed_settings.cc

+++ b/chrome/browser/chromeos/login/signed_settings.cc

@@ -334,7 +334,6 @@ CheckWhitelistOp::CheckWhitelistOp(const std::string& email,

CheckWhitelistOp::~CheckWhitelistOp() {}

void CheckWhitelistOp::Execute() {

- CHECK(chromeos::CrosLibrary::Get()->EnsureLoaded());

std::vector<uint8> sig;

std::string email_to_check = email_;

if (!service_->has_cached_policy()) {

@@ -655,7 +654,6 @@ RetrievePropertyOp::RetrievePropertyOp(const std::string& name,

RetrievePropertyOp::~RetrievePropertyOp() {}

void RetrievePropertyOp::Execute() {

- CHECK(chromeos::CrosLibrary::Get()->EnsureLoaded());

// TODO(dilmah): Fix the race:

// At the moment when device becomes owned there is lapse of time after

// device has been owned and before temp_storage settings are finally