Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: chrome/browser/chromeos/login/screen_locker.cc

Issue 8588006: Eliminate CrosLibrary::EnsureLoaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screen_locker.cc
diff --git a/chrome/browser/chromeos/login/screen_locker.cc b/chrome/browser/chromeos/login/screen_locker.cc
index e728b90075fd7a21a4f48812ef4209fa9b1eb4be..6fc836ef1ed6366f099ef3498ac7cfe10d3cbcc6 100644
--- a/chrome/browser/chromeos/login/screen_locker.cc
+++ b/chrome/browser/chromeos/login/screen_locker.cc
@@ -70,8 +70,7 @@ class ScreenLockObserver : public chromeos::ScreenLockLibrary::Observer,
if (type == chrome::NOTIFICATION_LOGIN_USER_CHANGED) {
// Register Screen Lock after login screen to make sure
// we don't show the screen lock on top of the login screen by accident.
- if (chromeos::CrosLibrary::Get()->EnsureLoaded())
- chromeos::CrosLibrary::Get()->GetScreenLockLibrary()->AddObserver(this);
+ chromeos::CrosLibrary::Get()->GetScreenLockLibrary()->AddObserver(this);
}
}
@@ -272,8 +271,7 @@ void ScreenLocker::OnLoginSuccess(
service->SetPassphrase(password, false);
}
}
- if (CrosLibrary::Get()->EnsureLoaded())
- CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenUnlockRequested();
+ CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenUnlockRequested();
if (login_status_consumer_)
login_status_consumer_->OnLoginSuccess(username, password,
@@ -373,8 +371,7 @@ void ScreenLocker::Show() {
// receive the response within timeout. Just send complete
// signal.
VLOG(1) << "Show: locker already exists. Just sending completion event.";
- if (CrosLibrary::Get()->EnsureLoaded())
- CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenLockCompleted();
+ CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenLockCompleted();
}
}
@@ -428,8 +425,7 @@ ScreenLocker::~ScreenLocker() {
chrome::NOTIFICATION_SCREEN_LOCK_STATE_CHANGED,
content::Source<ScreenLocker>(this),
content::Details<bool>(&state));
- if (CrosLibrary::Get()->EnsureLoaded())
- CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenUnlockCompleted();
+ CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenUnlockCompleted();
}
void ScreenLocker::SetAuthenticator(Authenticator* authenticator) {
@@ -448,8 +444,7 @@ void ScreenLocker::ScreenLockReady() {
chrome::NOTIFICATION_SCREEN_LOCK_STATE_CHANGED,
content::Source<ScreenLocker>(this),
content::Details<bool>(&state));
- if (CrosLibrary::Get()->EnsureLoaded())
- CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenLockCompleted();
+ CrosLibrary::Get()->GetScreenLockLibrary()->NotifyScreenLockCompleted();
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/parallel_authenticator.cc ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698