Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1933)

Unified Diff: chrome/browser/chromeos/sms_observer.cc

Issue 8588006: Eliminate CrosLibrary::EnsureLoaded (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/sms_observer.cc
diff --git a/chrome/browser/chromeos/sms_observer.cc b/chrome/browser/chromeos/sms_observer.cc
index 3bbb4b1c288d5829713fe334dc1c4ec9fdff902d..46fb8ec1a91badc2f460cc61881930b3f144c8ef 100644
--- a/chrome/browser/chromeos/sms_observer.cc
+++ b/chrome/browser/chromeos/sms_observer.cc
@@ -18,9 +18,6 @@ namespace chromeos {
SmsObserver::SmsObserver(Profile* profile)
: profile_(profile) {
DCHECK(profile_);
- if (!CrosLibrary::Get()->EnsureLoaded())
- return;
-
UpdateObservers(chromeos::CrosLibrary::Get()->GetNetworkLibrary());
}
@@ -31,8 +28,7 @@ SmsObserver::~SmsObserver() {
}
void SmsObserver::UpdateObservers(NetworkLibrary* library) {
- if (!CrosLibrary::Get()->EnsureLoaded() ||
- !CrosLibrary::Get()->GetNetworkLibrary()->IsCros())
+ if (!CrosLibrary::Get()->libcros_loaded())
satorux1 2011/11/16 23:51:34 This is a valid check. Let's add some comment like
stevenjb 2011/11/17 00:23:33 Done.
return;
const CellularNetworkVector& networks = library->cellular_networks();
@@ -78,8 +74,7 @@ void SmsObserver::UpdateObservers(NetworkLibrary* library) {
}
void SmsObserver::DisconnectAll() {
- if (!CrosLibrary::Get()->EnsureLoaded() ||
- !CrosLibrary::Get()->GetNetworkLibrary()->IsCros())
+ if (!CrosLibrary::Get()->libcros_loaded())
return;
for (ObserversMap::iterator it = observers_.begin();

Powered by Google App Engine
This is Rietveld 408576698