Eliminate CrosLibrary::EnsureLoaded

chrome/browser/ui/browser_list.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_list.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "build/build_config.h"
@@ skipping 209 matching lines @@
 
 #if defined(OS_CHROMEOS)
 
 // Whether a session manager requested to shutdown.
 bool g_session_manager_requested_shutdown = true;
 
 // Fast shutdown for ChromeOS. It tells session manager to start
 // shutdown process when closing browser windows won't be canceled.
 // Returns true if fast shutdown is successfully started.
 bool FastShutdown() {
-  if (chromeos::CrosLibrary::Get()->EnsureLoaded()
+  if (chromeos::CrosLibrary::Get()->libcros_loaded()

[satorux1, 2011/11/16 23:51:34]

we don't need to call this, as it's also checked in
BrowserList::NotifyAndTerminate()

[stevenjb, 2011/11/17 00:23:33]

But it does affect the return value, so I didn't want to mess with it yet. Did
replace with system::runtime_environment::IsRunningOnChromeOS() though.

       && AreAllBrowsersCloseable()) {
     BrowserList::NotifyAndTerminate(true);
     return true;
   }
   return false;
 }
 
 void NotifyWindowManagerAboutSignout() {
 #if defined(TOOLKIT_USES_GTK)
   static bool notified = false;
@@ skipping 71 matching lines @@
     return;
   notified = true;
 #endif
 
   if (fast_path)
     NotifyAppTerminating();
 
 #if defined(OS_CHROMEOS)
   NotifyWindowManagerAboutSignout();
   chromeos::CrosLibrary* cros_library = chromeos::CrosLibrary::Get();
-  if (cros_library->EnsureLoaded()) {
+  if (cros_library->libcros_loaded()) {

[satorux1, 2011/11/16 23:51:34]

I think system::runtime_environment::IsRunningOnChromeOS() should be used
instead 

[stevenjb, 2011/11/17 00:23:33]

Done.

     // If update has been installed, reboot, otherwise, sign out.
     if (cros_library->GetUpdateLibrary()->status().status ==
           chromeos::UPDATE_STATUS_UPDATED_NEED_REBOOT) {
       cros_library->GetUpdateLibrary()->RebootAfterUpdate();
     } else {
       chromeos::DBusThreadManager::Get()->GetSessionManagerClient()
           ->StopSession();
     }
     return;
   }
   // If running the Chrome OS build, but we're not on the device, fall through

[satorux1, 2011/11/16 23:51:34]

per this comment.

[stevenjb, 2011/11/17 00:23:33]

Done.

 #endif
   AllBrowsersClosedAndAppExiting();
 }
 
 // static
 void BrowserList::RemoveBrowser(Browser* browser) {
   RemoveBrowserFrom(browser, &last_active_browsers_);
 
   // Closing all windows does not indicate quitting the application on the Mac,
   // however, many UI tests rely on this behavior so leave it be for now and
@@ skipping 471 matching lines @@
   // If no more TabContents from Browsers, check the BackgroundPrintingManager.
   while (bg_printing_iterator_ != GetBackgroundPrintingManager()->end()) {
     cur_ = *bg_printing_iterator_;
     CHECK(cur_);
     ++bg_printing_iterator_;
     return;
   }
   // Reached the end - no more TabContents.
   cur_ = NULL;
 }