Issue 8588004: MIPS: Fixed a minor inconsistency in lithium-codegen-mips.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8588004: MIPS: Fixed a minor inconsistency in lithium-codegen-mips.cc (Closed)

Created:
9 years, 1 month ago by kisg

Modified:
9 years, 1 month ago

Reviewers:
Paul Lind, danno

CC:
v8-dev

Visibility:
Public.

Description

MIPS: Fixed a minor inconsistency in lithium-codegen-mips.cc EmitIsObject is only called from one function, DoIsObjectAndBranch. DoIsObjectAndBranch now passes the temp2 register to EmitIsObject instead of simply relying on the two functions using the same lithium scratch register. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10017

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/mips/lithium-codegen-mips.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/mips/lithium-codegen-mips.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages