Issue 8587055: Revert 110557 - Use nacl::CreateMemoryObject to create dynamic code shared memory object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8587055: Revert 110557 - Use nacl::CreateMemoryObject to create dynamic code shared memory object (Closed)

Created:
9 years, 1 month ago by awong

Modified:
9 years, 1 month ago

Reviewers:
Roland McGrath

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 110557 - Use nacl::CreateMemoryObject to create dynamic code shared memory object Use NaCl's code rather than base::SharedMemory to create the shared memory object to whose mappings NaCl needs to apply PROT_EXEC. We'll be changing that NaCl code to deal with the Linux cases where shm_open objects cannot have PROT_EXEC applied to their mappings. BUG= http://code.google.com/p/chromium/issues/detail?id=103377 TEST= nacl_integration R=mseaborn@chromium.org Review URL: http://codereview.chromium.org/8574065 TBR=mcgrathr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110571

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	M	chrome/browser/nacl_host/nacl_process_host.cc	View		1 chunk	+12 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Roland McGrath

9 years, 1 month ago (2011-11-17 22:22:04 UTC) #2

LGTM.  Will resubmit a version that copes with DISABLE_NACL.