Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: remoting/protocol/jingle_session.h

Issue 8587053: Remove event_channel() and control_channel() from Session interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/host_event_dispatcher.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/jingle_session.h
diff --git a/remoting/protocol/jingle_session.h b/remoting/protocol/jingle_session.h
index cc5195aace9131d6387c50accc6847b05ddd765d..b2f831b7e7aa2602d562d10a304678db6ebc2002 100644
--- a/remoting/protocol/jingle_session.h
+++ b/remoting/protocol/jingle_session.h
@@ -37,8 +37,6 @@ class JingleSession : public protocol::Session,
const std::string& name,
const DatagramChannelCallback& callback) OVERRIDE;
virtual void CancelChannelCreation(const std::string& name) OVERRIDE;
- virtual net::Socket* control_channel() OVERRIDE;
- virtual net::Socket* event_channel() OVERRIDE;
virtual const std::string& jid() OVERRIDE;
virtual const CandidateSessionConfig* candidate_config() OVERRIDE;
virtual const SessionConfig& config() OVERRIDE;
@@ -121,16 +119,6 @@ class JingleSession : public protocol::Session,
void OnChannelConnectorFinished(const std::string& name,
JingleChannelConnector* connector);
- // Creates channels after session has been accepted.
- // TODO(sergeyu): Don't create channels in JingleSession.
- void CreateChannels();
-
- // Callbacks for the channels created in JingleSession.
- // TODO(sergeyu): Remove this method once *_channel() methods are
- // removed from Session interface.
- void OnChannelConnected(scoped_ptr<net::Socket>* socket_container,
- net::StreamSocket* socket);
-
const cricket::ContentInfo* GetContentInfo() const;
void SetState(State new_state);
@@ -180,9 +168,6 @@ class JingleSession : public protocol::Session,
// Channels that are currently being connected.
ChannelConnectorsMap channel_connectors_;
- scoped_ptr<net::Socket> control_channel_socket_;
- scoped_ptr<net::Socket> event_channel_socket_;
-
ScopedRunnableMethodFactory<JingleSession> task_factory_;
DISALLOW_COPY_AND_ASSIGN(JingleSession);
« no previous file with comments | « remoting/protocol/host_event_dispatcher.cc ('k') | remoting/protocol/jingle_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698