Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 8587052: When allowing an extension file:/// URL access, grant its process access to that scheme. (Closed)

Created:
9 years, 1 month ago by Mihai Parparita -not on Chrome
Modified:
9 years, 1 month ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, Erik does not do reviews, Paweł Hajdan Jr., mihaip+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

When allowing an extension file:/// URL access, grant its process access to that scheme. This allows XHRs from the background page to file:/// URLs to succeed. XHRs from content scripts still fail, since they're running in a regular renderer process, and there is currently no mechanism for only whitelisting the isolated world within it for the file: scheme. Also re-enable ExtensionApiTest.CrossOriginXHRContentScript since it doesn't appear to have flaked recently. BUG=104547, 96725 R=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110614

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indentation #

Messages

Total messages: 5 (0 generated)
Mihai Parparita -not on Chrome
9 years, 1 month ago (2011-11-17 21:26:45 UTC) #1
Aaron Boodman
lgtm http://codereview.chromium.org/8587052/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc File chrome/browser/renderer_host/chrome_render_view_host_observer.cc (right): http://codereview.chromium.org/8587052/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc#newcode119 chrome/browser/renderer_host/chrome_render_view_host_observer.cc:119: if (type == Extension::TYPE_EXTENSION && profile_->GetExtensionService()-> Weird indent ...
9 years, 1 month ago (2011-11-17 21:31:23 UTC) #2
Mihai Parparita -not on Chrome
http://codereview.chromium.org/8587052/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc File chrome/browser/renderer_host/chrome_render_view_host_observer.cc (right): http://codereview.chromium.org/8587052/diff/1/chrome/browser/renderer_host/chrome_render_view_host_observer.cc#newcode119 chrome/browser/renderer_host/chrome_render_view_host_observer.cc:119: if (type == Extension::TYPE_EXTENSION && profile_->GetExtensionService()-> On 2011/11/17 21:31:23, ...
9 years, 1 month ago (2011-11-17 23:14:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/8587052/3001
9 years, 1 month ago (2011-11-17 23:17:30 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-18 00:32:58 UTC) #5
Change committed as 110614

Powered by Google App Engine
This is Rietveld 408576698