Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 8587045: Revert 110529 - Allow chrome to handle 407 auth challenges to CONNECT requests (Closed)

Created:
9 years, 1 month ago by Ryan Hamilton
Modified:
9 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 110529 - Allow chrome to handle 407 auth challenges to CONNECT requests through HTTPS Proxies. This also changes the mechanism used to restart HttpProxyClientSocket requests with auth. Previously the transport socket would be Disconnected, and then re-Connected (which was not implemented for SSLClientSockets). However, the approach was problematic in the face of, for example, ipv6. The new approach is to close the HttpProxyClientSocket, and request a new socket from the pool. Review URL: http://codereview.chromium.org/8502024 TBR=rch@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -583 lines) Patch
M net/http/http_network_transaction_unittest.cc View 12 chunks +13 lines, -409 lines 0 comments Download
MM net/http/http_proxy_client_socket.h View 5 chunks +15 lines, -2 lines 0 comments Download
MM net/http/http_proxy_client_socket.cc View 7 chunks +37 lines, -8 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 2 chunks +11 lines, -19 lines 0 comments Download
M net/http/http_proxy_utils.h View 3 chunks +1 line, -10 lines 0 comments Download
M net/http/http_proxy_utils.cc View 2 chunks +1 line, -19 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/http/proxy_client_socket.h View 2 chunks +0 lines, -10 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket.h View 1 chunk +8 lines, -2 lines 0 comments Download
MM net/spdy/spdy_proxy_client_socket.cc View 2 chunks +0 lines, -23 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 6 chunks +2 lines, -72 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ryan Hamilton
9 years, 1 month ago (2011-11-17 20:45:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698