Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 8587044: Minor refactoring to about:profiler to avoid long parameter lists. (Make some functions into meth... (Closed)

Created:
9 years, 1 month ago by eroman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Minor refactoring to about:profiler to avoid long parameter lists. (Make some functions into methods). BUG=100992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110549

Patch Set 1 #

Patch Set 2 : move the function into prototype (purely moving code, no edits) #

Patch Set 3 : Actual changes... #

Patch Set 4 : Remove an empy line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -170 lines) Patch
M chrome/browser/resources/profiler.js View 1 2 3 3 chunks +159 lines, -170 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eroman
IMPORTANT: To make this review easier, please review just the deltas with respect to patchset ...
9 years, 1 month ago (2011-11-17 20:21:32 UTC) #1
jar (doing other things)
9 years, 1 month ago (2011-11-17 20:28:40 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698