Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: content/browser/download/download_state_info.cc

Issue 8587042: Update the windows UI to support displaying a warning after the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/download/download_item_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_state_info.cc
===================================================================
--- content/browser/download/download_state_info.cc (revision 110657)
+++ content/browser/download/download_state_info.cc (working copy)
@@ -42,11 +42,13 @@
}
bool DownloadStateInfo::IsDangerous() const {
- // TODO(noelutz): At this point we can't mark the download as dangerous
- // if it's content is dangerous because the UI doesn't yet support it.
- // Once the UI has been changed we should return true when the danger
- // type is set to DANGEROUS_CONTENT.
- // |dangerous_content| is true.
+ // TODO(noelutz): At this point only the windows views UI supports
+ // warnings based on dangerous content.
+#ifdef OS_WIN
return (danger == DANGEROUS_FILE ||
- danger == DANGEROUS_URL);
+ danger == DANGEROUS_URL ||
+ danger == DANGEROUS_CONTENT);
+#else
+ return (danger == DANGEROUS_FILE || danger == DANGEROUS_URL);
+#endif
}
« no previous file with comments | « chrome/browser/ui/views/download/download_item_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698