Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 8587036: Fix link issue when component=shared_library (Closed)

Created:
9 years, 1 month ago by Peng
Modified:
9 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org
Visibility:
Public.

Description

Fix link issue when component=shared_library BUG=104622 TEST=GYP_DEFINES="component=shared_library" and build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110542

Patch Set 1 #

Patch Set 2 : Fix window build issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M content/browser/gpu/gpu_process_host_ui_shim.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_linux.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Peng
9 years, 1 month ago (2011-11-17 17:12:24 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-17 17:15:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/8587036/1
9 years, 1 month ago (2011-11-17 18:42:07 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 20:05:56 UTC) #4
Change committed as 110542

Powered by Google App Engine
This is Rietveld 408576698