content/browser/tab_contents/tab_contents.cc - Issue 8587029: Fixed race-condition in RenderViewHost(Manager)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/tab_contents.cc

Issue 8587029: Fixed race-condition in RenderViewHost(Manager) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Uploaded with correct base branch Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/tab_contents/tab_contents.cc

diff --git a/content/browser/tab_contents/tab_contents.cc b/content/browser/tab_contents/tab_contents.cc

index d9effbc44f03af604b34ec7642086e50621a6ba9..4bad523f62b0b018be869b2611d82f5812ae5cc2 100644

--- a/content/browser/tab_contents/tab_contents.cc

+++ b/content/browser/tab_contents/tab_contents.cc

@@ -99,6 +99,12 @@

// - The previous renderer is kept swapped out in RenderViewHostManager in case

// the user goes back. The process only stays live if another tab is using

// it, but if so, the existing frame relationships will be maintained.

+//

+// It is possible that we trigger a new navigation after we have received

+// a SwapOut_ACK message but before the FrameNavigation has been confirmed.

+// In this case the old RVH has been swapped out but the new one has not

+// replaced it, yet. Therefore, we cancel the pending RVH and skip the unloading

Charlie Reis 2011/11/21 19:29:02 Nit: skip -> avoid unloading the old RVH a second

+// of the old RVH.

namespace {