Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2111)

Unified Diff: chrome/browser/extensions/settings/settings_frontend_unittest.cc

Issue 8587025: Extension settings API: force through changes that come from sync (ignoring (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_frontend_unittest.cc
diff --git a/chrome/browser/extensions/settings/settings_frontend_unittest.cc b/chrome/browser/extensions/settings/settings_frontend_unittest.cc
index 7b2345fd3ed9273b24f17d450f31fc7098d793c0..cbebf43339091bf998518acb22b5ccb0377a75c6 100644
--- a/chrome/browser/extensions/settings/settings_frontend_unittest.cc
+++ b/chrome/browser/extensions/settings/settings_frontend_unittest.cc
@@ -23,6 +23,9 @@ using namespace settings_test_util;
namespace {
+// To save typing SettingsStorage::DEFAULTS everywhere.
+const SettingsStorage::WriteOptions DEFAULTS = SettingsStorage::DEFAULTS;
+
// A SettingsStorageFactory which always returns NULL.
class NullSettingsStorageFactory : public SettingsStorageFactory {
public:
@@ -89,7 +92,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsPreservedAcrossReconstruction) {
// be too rigorous.
{
StringValue bar("bar");
- SettingsStorage::WriteResult result = storage->Set("foo", bar);
+ SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_FALSE(result.HasError());
}
@@ -118,7 +121,7 @@ TEST_F(ExtensionSettingsFrontendTest, SettingsClearedOnUninstall) {
{
StringValue bar("bar");
- SettingsStorage::WriteResult result = storage->Set("foo", bar);
+ SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_FALSE(result.HasError());
}
@@ -144,7 +147,7 @@ TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
{
StringValue bar("bar");
- SettingsStorage::WriteResult result = storage->Set("foo", bar);
+ SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
ASSERT_FALSE(result.HasError());
EXPECT_TRUE(file_util::PathExists(temp_dir_.path()));
}
@@ -179,7 +182,7 @@ TEST_F(ExtensionSettingsFrontendTest,
EXPECT_TRUE(storage->Get().HasError());
EXPECT_TRUE(storage->Clear().HasError());
- EXPECT_TRUE(storage->Set("foo", bar).HasError());
+ EXPECT_TRUE(storage->Set(DEFAULTS, "foo", bar).HasError());
EXPECT_TRUE(storage->Remove("foo").HasError());
// For simplicity: just always fail those requests, even if the leveldb
@@ -191,7 +194,7 @@ TEST_F(ExtensionSettingsFrontendTest,
EXPECT_TRUE(storage->Get().HasError());
EXPECT_TRUE(storage->Clear().HasError());
- EXPECT_TRUE(storage->Set("foo", bar).HasError());
+ EXPECT_TRUE(storage->Set(DEFAULTS, "foo", bar).HasError());
EXPECT_TRUE(storage->Remove("foo").HasError());
}
« no previous file with comments | « chrome/browser/extensions/settings/settings_api.cc ('k') | chrome/browser/extensions/settings/settings_leveldb_storage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698