Extension settings API: force through changes that come from sync (ignoring

chrome/browser/extensions/settings/settings_frontend_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "chrome/browser/extensions/settings/settings_frontend.h"
 #include "chrome/browser/extensions/settings/settings_storage.h"
 #include "chrome/browser/extensions/settings/settings_test_util.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/test/test_browser_thread.h"
 
 namespace extensions {
 
 using content::BrowserThread;
 
 using namespace settings_test_util;
 
 namespace {
 
+// To save typing SettingsStorage::DEFAULTS everywhere.
+const SettingsStorage::WriteOptions DEFAULTS = SettingsStorage::DEFAULTS;
+
 // A SettingsStorageFactory which always returns NULL.
 class NullSettingsStorageFactory : public SettingsStorageFactory {
  public:
   virtual ~NullSettingsStorageFactory() {}
 
   // SettingsStorageFactory implementation.
   virtual SettingsStorage* Create(
       const FilePath& base_path, const std::string& extension_id) OVERRIDE {
     return NULL;
   }
@@ skipping 46 matching lines @@
   const std::string id = "ext";
   profile_->GetMockExtensionService()->AddExtension(
       id, Extension::TYPE_EXTENSION);
 
   SettingsStorage* storage = GetStorage(id, frontend_.get());
 
   // The correctness of Get/Set/Remove/Clear is tested elsewhere so no need to
   // be too rigorous.
   {
     StringValue bar("bar");
-    SettingsStorage::WriteResult result = storage->Set("foo", bar);
+    SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
     ASSERT_FALSE(result.HasError());
   }
 
   {
     SettingsStorage::ReadResult result = storage->Get();
     ASSERT_FALSE(result.HasError());
     EXPECT_FALSE(result.settings().empty());
   }
 
   ResetFrontend();
   storage = GetStorage(id, frontend_.get());
 
   {
     SettingsStorage::ReadResult result = storage->Get();
     ASSERT_FALSE(result.HasError());
     EXPECT_FALSE(result.settings().empty());
   }
 }
 
 TEST_F(ExtensionSettingsFrontendTest, SettingsClearedOnUninstall) {
   const std::string id = "ext";
   profile_->GetMockExtensionService()->AddExtension(
       id, Extension::TYPE_PACKAGED_APP);
 
   SettingsStorage* storage = GetStorage(id, frontend_.get());
 
   {
     StringValue bar("bar");
-    SettingsStorage::WriteResult result = storage->Set("foo", bar);
+    SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
     ASSERT_FALSE(result.HasError());
   }
 
   // This would be triggered by extension uninstall via an ExtensionDataDeleter.
   frontend_->DeleteStorageSoon(id);
   MessageLoop::current()->RunAllPending();
 
   // The storage area may no longer be valid post-uninstall, so re-request.
   storage = GetStorage(id, frontend_.get());
   {
     SettingsStorage::ReadResult result = storage->Get();
     ASSERT_FALSE(result.HasError());
     EXPECT_TRUE(result.settings().empty());
   }
 }
 
 TEST_F(ExtensionSettingsFrontendTest, LeveldbDatabaseDeletedFromDiskOnClear) {
   const std::string id = "ext";
   profile_->GetMockExtensionService()->AddExtension(
       id, Extension::TYPE_EXTENSION);
 
   SettingsStorage* storage = GetStorage(id, frontend_.get());
 
   {
     StringValue bar("bar");
-    SettingsStorage::WriteResult result = storage->Set("foo", bar);
+    SettingsStorage::WriteResult result = storage->Set(DEFAULTS, "foo", bar);
     ASSERT_FALSE(result.HasError());
     EXPECT_TRUE(file_util::PathExists(temp_dir_.path()));
   }
 
   // Should need to both clear the database and delete the frontend for the
   // leveldb database to be deleted from disk.
   {
-    SettingsStorage::WriteResult result = storage->Clear();
+    SettingsStorage::WriteResult result = storage->Clear(DEFAULTS);
     ASSERT_FALSE(result.HasError());
     EXPECT_TRUE(file_util::PathExists(temp_dir_.path()));
   }
 
   frontend_.reset();
   MessageLoop::current()->RunAllPending();
   // TODO(kalman): Figure out why this fails, despite appearing to work.
   // Leaving this commented out rather than disabling the whole test so that the
   // deletion code paths are at least exercised.
   //EXPECT_FALSE(file_util::PathExists(temp_dir_.path()));
 }
 
 TEST_F(ExtensionSettingsFrontendTest,
     LeveldbCreationFailureFailsAllOperations) {
   const StringValue bar("bar");
   const std::string id = "ext";
   profile_->GetMockExtensionService()->AddExtension(
       id, Extension::TYPE_EXTENSION);
 
   storage_factory_->Reset(new NullSettingsStorageFactory());
 
   SettingsStorage* storage = GetStorage(id, frontend_.get());
   ASSERT_TRUE(storage != NULL);
 
   EXPECT_TRUE(storage->Get().HasError());
-  EXPECT_TRUE(storage->Clear().HasError());
-  EXPECT_TRUE(storage->Set("foo", bar).HasError());
-  EXPECT_TRUE(storage->Remove("foo").HasError());
+  EXPECT_TRUE(storage->Clear(DEFAULTS).HasError());
+  EXPECT_TRUE(storage->Set(DEFAULTS, "foo", bar).HasError());
+  EXPECT_TRUE(storage->Remove(DEFAULTS, "foo").HasError());
 
   // For simplicity: just always fail those requests, even if the leveldb
   // storage areas start working.
   storage_factory_->Reset(new SettingsLeveldbStorage::Factory());
 
   storage = GetStorage(id, frontend_.get());
   ASSERT_TRUE(storage != NULL);
 
   EXPECT_TRUE(storage->Get().HasError());
-  EXPECT_TRUE(storage->Clear().HasError());
-  EXPECT_TRUE(storage->Set("foo", bar).HasError());
-  EXPECT_TRUE(storage->Remove("foo").HasError());
+  EXPECT_TRUE(storage->Clear(DEFAULTS).HasError());
+  EXPECT_TRUE(storage->Set(DEFAULTS, "foo", bar).HasError());
+  EXPECT_TRUE(storage->Remove(DEFAULTS, "foo").HasError());
 }
 
 }  // namespace extensions