[Sync] Add version info to about:sync

chrome/browser/sync/sync_ui_util.cc

Index: chrome/browser/sync/sync_ui_util.cc
diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc
index 7264b48addc47d9d5180c074389d9cfa0e5baca4..8bea9b168b5c1ea895d79f701da78ed8ba017afd 100644
--- a/chrome/browser/sync/sync_ui_util.cc
+++ b/chrome/browser/sync/sync_ui_util.cc
@@ -18,6 +18,7 @@
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_version_info.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "chrome/common/url_constants.h"
 #include "grit/browser_resources.h"
@@ -491,6 +492,10 @@ void ConstructAboutInformation(ProfileSyncService* service,
                        ProfileSyncService::BuildSyncStatusSummaryText(
                        full_status.summary));
 
+    chrome::VersionInfo chrome_version;
+    strings->SetString("version", chrome_version.Name() + " " +

[akalin, 2011/11/17 02:35:02]

Does this have more information than the user agent?  (See
content::GetUserAgent() from content/public/common/content_client.h, and its use
in sync_backend_hsot.cc).

I would prefer the user agent, as it can be more easily compared with server
logs, etc.

WDYT?

[Nicolas Zea, 2011/11/17 03:59:16]

Hmm, wasn't aware of that. Interestingly, sync_backend_host.cc uses both the
content_client's GetUserAgent, as well as a special user agent for syncapi that
also makes use of VersionInfo (see MakeUserAgentForSyncApi). The string here is
almost the same as the syncapi user agent, with the exception that I also add
the channel, which I think is worth keeping around. I've gone ahead and matched
their formats though.

The content_client user agent specifies a lot more than we care to display
(webkit version, mozilla/safari things, etc.), and does not include the channel.

In addition, the server logs are keyed primarily off the cached_guid, which is
in neither of the above, but would be useful to provide. Added as a separate
field.

+        chrome_version.Version() + " (" + chrome_version.OSType() + ") " +
+        chrome_version.GetVersionStringModifier());
     strings->Set("authenticated",
                  new base::FundamentalValue(full_status.authenticated));
     strings->SetString("auth_problem",