[Sync] Add version info to about:sync

chrome/browser/sync/sync_ui_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_ui_util.h"
 
 #include "base/i18n/number_formatting.h"
 #include "base/i18n/time_formatting.h"
 #include "base/string_util.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/sync/profile_sync_service.h"
 #include "chrome/browser/sync/protocol/proto_enum_conversions.h"
 #include "chrome/browser/sync/protocol/sync_protocol_error.h"
 #include "chrome/browser/sync/syncable/model_type.h"
 #include "chrome/browser/sync/sessions/session_state.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/chrome_version_info.h"
 #include "chrome/common/net/gaia/google_service_auth_error.h"
 #include "chrome/common/url_constants.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 typedef GoogleServiceAuthError AuthError;
@@ skipping 453 matching lines @@
     strings->SetString("summary", "SYNC DISABLED");
   } else {
     sync_api::SyncManager::Status full_status(
         service->QueryDetailedSyncStatus());
 
     strings->SetString("service_url", service->sync_service_url().spec());
     strings->SetString("summary",
                        ProfileSyncService::BuildSyncStatusSummaryText(
                        full_status.summary));
 
+    // Build a version string that matches MakeUserAgentForSyncApi with the
+    // addition of channel info and proper OS names.
+    chrome::VersionInfo chrome_version;

[akalin, 2011/11/17 04:12:43]

Maybe a special string if VersionInfo is invalid

[Nicolas Zea, 2011/11/17 04:58:10]

Done.

+    std::string version_modifier =

[akalin, 2011/11/17 04:12:43]

Can you decomp the string-building logic into a separate function (in this file)
and add a TODO to look into unifying it with MakeUserAgentForSyncApi?

[Nicolas Zea, 2011/11/17 04:58:10]

Done.

+        " " + chrome::VersionInfo::GetVersionStringModifier();

[akalin, 2011/11/17 04:12:43]

Hmm docs for GetVersionStringModifier() say that it returns an empty string for
stable builds also.  May have to use GetChannel() to disambiguiate?

[Nicolas Zea, 2011/11/17 04:58:10]

Good catch. Done.

+    if (version_modifier == " ")  // Not set for unofficial builds.
+      version_modifier = "-devel";
+    strings->SetString("version", chrome_version.Name() + " " +
+        chrome_version.OSType() + " " + chrome_version.Version() + " (" +
+        chrome_version.LastChange() + ")" + version_modifier);
     strings->Set("authenticated",
                  new base::FundamentalValue(full_status.authenticated));
     strings->SetString("auth_problem",
                        sync_ui_util::MakeSyncAuthErrorText(
                        service->GetAuthError().state()));
 
     strings->SetString("time_since_sync", service->GetLastSyncedTimeString());
 
     ListValue* details = new ListValue();
     strings->Set("details", details);
     sync_ui_util::AddBoolSyncDetail(details, "Sync Initialized",
                                     service->sync_initialized());
     sync_ui_util::AddBoolSyncDetail(details, "Sync Setup Has Completed",
                                     service->HasSyncSetupCompleted());
+    sync_ui_util::AddStringSyncDetails(
+        details,
+        "Client ID",
+        full_status.unique_id == "" ? "none" : full_status.unique_id);

[akalin, 2011/11/17 04:12:43]

unique_id.empty()

[Nicolas Zea, 2011/11/17 04:58:10]

Done.

     sync_ui_util::AddBoolSyncDetail(details,
                                     "Server Up",
                                     full_status.server_up);
     sync_ui_util::AddBoolSyncDetail(details,
                                     "Server Reachable",
                                     full_status.server_reachable);
     sync_ui_util::AddBoolSyncDetail(details,
                                     "Server Broken",
                                     full_status.server_broken);
     sync_ui_util::AddBoolSyncDetail(details,
@@ skipping 139 matching lines @@
         DictionaryValue* val = new DictionaryValue;
         val->SetString("model_type", ModelTypeToString(it->first));
         val->SetString("group", ModelSafeGroupToString(it->second));
         routing_info->Append(val);
       }
     }
   }
 }
 
 }  // namespace sync_ui_util